From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Gideon Israel Dsouza <gidisrael@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
geert@linux-m68k.org
Subject: Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))
Date: Wed, 5 Mar 2014 10:27:55 +1100 [thread overview]
Message-ID: <20140305102755.6e44b7e1e6eb62f01c41c018@canb.auug.org.au> (raw)
In-Reply-To: <20140304132604.5be1b967068f8e03820d2169@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Hi Andrew,
On Tue, 4 Mar 2014 13:26:04 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Sun, 2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza <gidisrael@gmail.com> wrote:
>
> > To increase compiler portability there is <linux/compiler.h> which
> > provides convenience macros for various gcc constructs. Eg: __weak
> > for __attribute__((weak)). I've replaced all instances of gcc
> > attributes with the right macro in the memory management
> > (/mm) subsystem.
> >
> > ...
> >
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -13,6 +13,7 @@
> > #include <linux/nodemask.h>
> > #include <linux/pagemap.h>
> > #include <linux/mempolicy.h>
> > +#include <linux/compiler.h>
>
> It may be overdoing things a bit to explicitly include compiler.h.
> It's hard to conceive of any .c file which doesn't already include it.
Stick to Rule 1 :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-04 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 13:39 [PATCH 0/1] mm: Use macros from compiler.h instead of gcc specific attribute Gideon Israel Dsouza
2014-03-02 13:39 ` [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...)) Gideon Israel Dsouza
2014-03-04 21:26 ` Andrew Morton
2014-03-04 23:27 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-01 16:02 [PATCH 0/1] Use macros from compiler.h instead of gcc specific attributes Gideon Israel Dsouza
2014-03-01 16:02 ` [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...)) Gideon Israel Dsouza
2014-03-01 17:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305102755.6e44b7e1e6eb62f01c41c018@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=gidisrael@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox