linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: mmotm 2014-03-03-15-24 uploaded
Date: Tue, 4 Mar 2014 12:03:02 +1100	[thread overview]
Message-ID: <20140304120302.7ee7f3a89b0e3c088479230d@canb.auug.org.au> (raw)
In-Reply-To: <20140303163921.48ab37bdfd9b895ee985a776@linux-foundation.org>


[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]

Hi Andrew,

On Mon, 3 Mar 2014 16:39:21 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 4 Mar 2014 11:36:10 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > I am carrying 5 fix patches for the above patch (they need to go before
> > or as part of the above patch).
> > 
> > ppc_Make_PPC_BOOK3S_64_select_IRQ_WORK.patch
> > ia64__select_CONFIG_TTY_for_use_of_tty_write_message_in_unaligned.patch
> > s390__select_CONFIG_TTY_for_use_of_tty_in_unconditional_keyboard_driver.patch
> > cris__Make_ETRAX_ARCH_V10_select_TTY_for_use_in_debugport.patch
> > cris__cpuinfo_op_should_depend_on_CONFIG_PROC_FS.patch
> > 
> > I can send them to you if you like,
> 
> Yes please.
> 
> > but I am pretty sure you were cc'd on all of them.
> 
> I hoped someone else was collecting them ;)

Attached (I hope that works for you)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: ppc_Make_PPC_BOOK3S_64_select_IRQ_WORK.patch --]
[-- Type: text/x-diff; name="ppc_Make_PPC_BOOK3S_64_select_IRQ_WORK.patch", Size: 1104 bytes --]

From: Josh Triplett <josh@joshtriplett.org>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK

arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls
functions only built when IRQ_WORK, so select it.  Fixes the following
build error:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 arch/powerpc/platforms/Kconfig.cputype | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index 434fda3..d9e2b19 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -73,6 +73,7 @@ config PPC_BOOK3S_64
 	select SYS_SUPPORTS_HUGETLBFS
 	select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES
 	select ARCH_SUPPORTS_NUMA_BALANCING
+	select IRQ_WORK
 
 config PPC_BOOK3E_64
 	bool "Embedded processors"
-- 
1.9.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: ia64__select_CONFIG_TTY_for_use_of_tty_write_message_in_unaligned.patch --]
[-- Type: text/x-diff; name="ia64__select_CONFIG_TTY_for_use_of_tty_write_message_in_unaligned.patch", Size: 1485 bytes --]

From: Josh Triplett <josh@joshtriplett.org>
To: kbuild test robot <fengguang.wu@intel.com>, Linux Memory Management List <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, kbuild-all@01.org, Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ia64: select CONFIG_TTY for use of tty_write_message in unaligned
Date: Wed, 26 Feb 2014 02:15:56 -0800

arch/ia64/kernel/unaligned.c uses tty_write_message to print an
unaligned access exception to the TTY of the current user process.
Enable TTY to prevent a build error.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
Not tested, but this *should* fix the build error with CONFIG_TTY=n.

Minimal fix, on the basis that few people on ia64 will care deeply about
kernel size enough to turn off TTY.  Ideally, I'd instead suggest
dropping the tty_write_message entirely, and just leaving the printk.
Bonus: no need to sprintf first.

 arch/ia64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 0c8e553..6b83c66 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -44,6 +44,7 @@ config IA64
 	select HAVE_MOD_ARCH_SPECIFIC
 	select MODULES_USE_ELF_RELA
 	select ARCH_USE_CMPXCHG_LOCKREF
+	select TTY
 	default y
 	help
 	  The Itanium Processor Family is Intel's 64-bit successor to
-- 
1.9.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.4: s390__select_CONFIG_TTY_for_use_of_tty_in_unconditional_keyboard_driver.patch --]
[-- Type: text/x-diff; name="s390__select_CONFIG_TTY_for_use_of_tty_in_unconditional_keyboard_driver.patch", Size: 1071 bytes --]

From: Josh Triplett <josh@joshtriplett.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Schwidefsky <schwidefsky@de.ibm.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, linux390@de.ibm.com, linux-s390@vger.kernel.org
Subject: [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver
Date: Wed, 26 Feb 2014 18:13:06 -0800

The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
error.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 arch/s390/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 65a0775..398efa1 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -140,6 +140,7 @@ config S390
 	select OLD_SIGACTION
 	select OLD_SIGSUSPEND3
 	select SYSCTL_EXCEPTION_TRACE
+	select TTY
 	select VIRT_CPU_ACCOUNTING
 	select VIRT_TO_BUS
 
-- 
1.9.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.5: cris__Make_ETRAX_ARCH_V10_select_TTY_for_use_in_debugport.patch --]
[-- Type: text/x-diff; name="cris__Make_ETRAX_ARCH_V10_select_TTY_for_use_in_debugport.patch", Size: 1051 bytes --]

From: Josh Triplett <josh@joshtriplett.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Mikael Starvik <starvik@axis.com>, Jesper Nilsson <jesper.nilsson@axis.com>, linux-cris-kernel@axis.com
Subject: [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport
Date: Thu, 27 Feb 2014 17:27:34 -0800

arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with
ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 arch/cris/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/cris/Kconfig b/arch/cris/Kconfig
index ed0fcdf..7cb90a5 100644
--- a/arch/cris/Kconfig
+++ b/arch/cris/Kconfig
@@ -138,6 +138,7 @@ config ETRAX_ARCH_V10
        bool
        default y if ETRAX100LX || ETRAX100LX_V2
        default n if !(ETRAX100LX || ETRAX100LX_V2)
+       select TTY
 
 config ETRAX_ARCH_V32
        bool
-- 
1.9.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.6: cris__cpuinfo_op_should_depend_on_CONFIG_PROC_FS.patch --]
[-- Type: text/x-diff; name="cris__cpuinfo_op_should_depend_on_CONFIG_PROC_FS.patch", Size: 1597 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Mikael Starvik <starvik@axis.com>, Jesper Nilsson <jesper.nilsson@axis.com>
Cc: linux-cris-kernel@axis.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH -next] cris: cpuinfo_op should depend on CONFIG_PROC_FS
Date: Sun,  2 Mar 2014 11:34:39 +0100

Now allnoconfig started disabling CONFIG_PROC_FS:

    arch/cris/kernel/built-in.o:(.rodata+0xc): undefined reference to `show_cpuinfo'
    make: *** [vmlinux] Error 1

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/10665698/

 arch/cris/kernel/setup.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c
index 32c3d248868e..905b70ea9939 100644
--- a/arch/cris/kernel/setup.c
+++ b/arch/cris/kernel/setup.c
@@ -165,6 +165,7 @@ void __init setup_arch(char **cmdline_p)
 	strcpy(init_utsname()->machine, cris_machine_name);
 }
 
+#ifdef CONFIG_PROC_FS
 static void *c_start(struct seq_file *m, loff_t *pos)
 {
 	return *pos < nr_cpu_ids ? (void *)(int)(*pos + 1) : NULL;
@@ -188,6 +189,7 @@ const struct seq_operations cpuinfo_op = {
 	.stop  = c_stop,
 	.show  = show_cpuinfo,
 };
+#endif /* CONFIG_PROC_FS */
 
 static int __init topology_init(void)
 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2014-03-04  1:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 23:25 akpm
2014-03-04  0:36 ` Stephen Rothwell
2014-03-04  0:39   ` Andrew Morton
2014-03-04  1:03     ` Stephen Rothwell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304120302.7ee7f3a89b0e3c088479230d@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox