From: Seth Jennings <sjennings@variantweb.net>
To: SeongJae Park <sj38.park@gmail.com>
Cc: sjenning@linux.vnet.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: zswap: remove unnecessary parentheses
Date: Mon, 3 Mar 2014 08:39:48 -0600 [thread overview]
Message-ID: <20140303143948.GA3362@cerebellum.variantweb.net> (raw)
In-Reply-To: <1393839476-24989-1-git-send-email-sj38.park@gmail.com>
On Mon, Mar 03, 2014 at 06:37:56PM +0900, SeongJae Park wrote:
> Fix following trivial checkpatch error:
> ERROR: return is not a function, parentheses are not required
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Thanks for the cleanup.
Might copy trivial@kernel.org on patches like this in the future.
Acked-by: Seth Jennings <sjennings@variantweb.net>
> ---
> mm/zswap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index c0c9b7c..34b75cc 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -204,7 +204,7 @@ static struct kmem_cache *zswap_entry_cache;
> static int zswap_entry_cache_create(void)
> {
> zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
> - return (zswap_entry_cache == NULL);
> + return zswap_entry_cache == NULL;
> }
>
> static void zswap_entry_cache_destory(void)
> @@ -408,8 +408,8 @@ cleanup:
> **********************************/
> static bool zswap_is_full(void)
> {
> - return (totalram_pages * zswap_max_pool_percent / 100 <
> - zswap_pool_pages);
> + return totalram_pages * zswap_max_pool_percent / 100 <
> + zswap_pool_pages;
> }
>
> /*********************************
> --
> 1.8.3.2
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-03-03 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 9:37 SeongJae Park
2014-03-03 14:39 ` Seth Jennings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303143948.GA3362@cerebellum.variantweb.net \
--to=sjennings@variantweb.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj38.park@gmail.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox