From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] slab: makes clear_obj_pfmemalloc() just return store masked value
Date: Mon, 17 Feb 2014 15:15:02 +0900 [thread overview]
Message-ID: <20140217061502.GB3468@lge.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1402141824300.5204@nuc>
On Fri, Feb 14, 2014 at 06:26:15PM -0600, Christoph Lameter wrote:
> On Fri, 14 Feb 2014, David Rientjes wrote:
>
> > Yeah, you don't need it, but don't you think it makes the code more
> > readable? Otherwise this is going to be just doing
> >
> > return (unsigned long)objp & ~SLAB_OBJ_PFMEMALLOC;
> >
> > and you gotta figure out the function type to understand it's returned as
>
> Isnt there something like PTR_ALIGN() for this case that would make it
> more readable?
I can't find what you want.
I agree with David's opinion and want to keep patch as is.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-17 6:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 6:57 [PATCH 0/9] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
2014-02-14 6:57 ` [PATCH 1/9] slab: add unlikely macro to help compiler Joonsoo Kim
2014-02-14 23:15 ` David Rientjes
2014-02-14 6:57 ` [PATCH 2/9] slab: makes clear_obj_pfmemalloc() just return store masked value Joonsoo Kim
2014-02-14 18:27 ` Christoph Lameter
2014-02-14 23:18 ` David Rientjes
2014-02-15 0:26 ` Christoph Lameter
2014-02-17 6:15 ` Joonsoo Kim [this message]
2014-02-14 6:57 ` [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block() Joonsoo Kim
2014-02-14 18:25 ` Christoph Lameter
2014-02-14 23:19 ` David Rientjes
2014-02-17 6:23 ` Joonsoo Kim
2014-02-14 6:57 ` [PATCH 4/9] slab: defer slab_destroy " Joonsoo Kim
2014-02-14 18:39 ` Christoph Lameter
2014-02-14 6:57 ` [PATCH 5/9] slab: factor out initialization of arracy cache Joonsoo Kim
2014-02-14 18:41 ` Christoph Lameter
2014-02-14 6:57 ` [PATCH 6/9] slab: introduce alien_cache Joonsoo Kim
2014-02-14 18:46 ` Christoph Lameter
2014-02-14 6:57 ` [PATCH 7/9] slab: use the lock on alien_cache, instead of the lock on array_cache Joonsoo Kim
2014-02-14 18:47 ` Christoph Lameter
2014-02-14 6:57 ` [PATCH 8/9] slab: destroy a slab without holding any alien cache lock Joonsoo Kim
2014-02-14 18:48 ` Christoph Lameter
2014-02-14 6:57 ` [PATCH 9/9] slab: remove a useless lockdep annotation Joonsoo Kim
2014-02-14 18:49 ` Christoph Lameter
2014-02-17 6:12 ` Joonsoo Kim
2014-02-18 16:21 ` Christoph Lameter
2014-02-24 4:49 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217061502.GB3468@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox