From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id 75BDC6B0031 for ; Mon, 10 Feb 2014 18:30:35 -0500 (EST) Received: by mail-pd0-f172.google.com with SMTP id p10so6728736pdj.31 for ; Mon, 10 Feb 2014 15:30:35 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id i8si16920460pav.132.2014.02.10.15.30.34 for ; Mon, 10 Feb 2014 15:30:34 -0800 (PST) Date: Mon, 10 Feb 2014 15:30:32 -0800 From: Andrew Morton Subject: Re: [PATCH 4/4] hugetlb: hugepagesnid=: add 1G huge page support Message-Id: <20140210153032.ac9325938264a3894dc83f8b@linux-foundation.org> In-Reply-To: <1392053268-29239-5-git-send-email-lcapitulino@redhat.com> References: <1392053268-29239-1-git-send-email-lcapitulino@redhat.com> <1392053268-29239-5-git-send-email-lcapitulino@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Luiz Capitulino Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, mgorman@suse.de, aarcange@redhat.com, andi@firstfloor.org, riel@redhat.com On Mon, 10 Feb 2014 12:27:48 -0500 Luiz Capitulino wrote: > > ... > > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2051,6 +2051,29 @@ void __init hugetlb_add_hstate(unsigned order) > parsed_hstate = h; > } > > +static void __init hugetlb_hstate_alloc_pages_nid(struct hstate *h, > + int nid, > + unsigned long nr_pages) > +{ > + struct huge_bootmem_page *m; > + unsigned long i; > + void *addr; > + > + for (i = 0; i < nr_pages; i++) { > + addr = memblock_virt_alloc_nid_nopanic( > + huge_page_size(h), huge_page_size(h), > + 0, BOOTMEM_ALLOC_ACCESSIBLE, nid); > + if (!addr) > + break; > + m = addr; > + BUG_ON((unsigned long)virt_to_phys(m) & (huge_page_size(h) - 1)); IS_ALIGNED()? > + list_add(&m->list, &huge_boot_pages); > + m->hstate = h; > + } > + > + h->max_huge_pages += i; > +} > + > void __init hugetlb_add_nrpages_nid(unsigned order, unsigned long nid, > unsigned long nr_pages) > { Please cc Yinghai Lu on these patches - he understands memblock well and is a strong reviewer. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org