Re: [PATCH] mm: bring back /sys/kernel/mm

[Paul Gortmaker <paul.gortmaker@windriver.com>]

[[PATCH] mm: bring back /sys/kernel/mm] On 26/01/2014 (Sun 18:52) Hugh Dickins wrote:

> Commit da29bd36224b ("mm/mm_init.c: make creation of the mm_kobj happen
> earlier than device_initcall") changed to pure_initcall(mm_sysfs_init).
> 
> That's too early: mm_sysfs_init() depends on core_initcall(ksysfs_init)
> to have made the kernel_kobj directory "kernel" in which to create "mm".
> 
> Make it postcore_initcall(mm_sysfs_init).  We could use core_initcall(),
> and depend upon Makefile link order kernel/ mm/ fs/ ipc/ security/ ...
> as core_initcall(debugfs_init) and core_initcall(securityfs_init) do;
> but better not.

Agreed, N+1 is better than link order.  I guess it silently fails then,
with /sys/kernel/mm missing as the symptom?  I'd booted i386 and ppc
and didn't spot this, unfortunately...  wondering now if there was a
hint in dmesg that I simply failed to notice.

> 
> Signed-off-by: Hugh Dickins <hughd@google.com>

Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Thanks,
Paul.

> ---
> 
>  mm/mm_init.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 3.13.0+/mm/mm_init.c	2014-01-23 21:51:26.004001378 -0800
> +++ linux/mm/mm_init.c	2014-01-26 18:06:40.488488209 -0800
> @@ -202,4 +202,4 @@ static int __init mm_sysfs_init(void)
>  
>  	return 0;
>  }
> -pure_initcall(mm_sysfs_init);
> +postcore_initcall(mm_sysfs_init);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>