From: Mel Gorman <mgorman@suse.de>
To: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, Dave Hansen <dave.hansen@intel.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [RFC] restore user defined min_free_kbytes when disabling thp
Date: Tue, 21 Jan 2014 10:23:51 +0000 [thread overview]
Message-ID: <20140121102351.GD4963@suse.de> (raw)
In-Reply-To: <20140121093859.GA7546@localhost.localdomain>
On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote:
> The testcase 'thp04' of LTP will enable THP, do some testing, then
> disable it if it wasn't enabled. But this will leave a different value
> of min_free_kbytes if it has been set by admin. So I think it's better
> to restore the user defined value after disabling THP.
>
Then have LTP record what min_free_kbytes was at the same time THP was
enabled by the test and restore both settings. It leaves a window where
an admin can set an alternative value during the test but that would also
invalidate the test in same cases and gets filed under "don't do that".
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-21 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 9:38 Han Pingtian
2014-01-21 10:23 ` Mel Gorman [this message]
2014-01-22 6:05 ` Han Pingtian
2014-01-22 9:40 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121102351.GD4963@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox