From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E.McKenney" <paulmck@linux.vnet.ibm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Waiman Long <waiman.long@hp.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Alex Shi <alex.shi@linaro.org>, Andi Kleen <andi@firstfloor.org>,
Michel Lespinasse <walken@google.com>,
Davidlohr Bueso <davidlohr.bueso@hp.com>,
Matthew R Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Rik van Riel <riel@redhat.com>,
Peter Hurley <peter@hurleysoftware.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
George Spelvin <linux@horizon.com>,
"H. Peter Anvin" <hpa@zytor.com>, Arnd Bergmann <arnd@arndb.de>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>,
"Figo.zhang" <figo1802@gmail.com>
Subject: Re: [PATCH v8 3/6] MCS Lock: optimizations and extra comments
Date: Tue, 21 Jan 2014 11:17:42 +0100 [thread overview]
Message-ID: <20140121101742.GR31570@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1390267468.3138.37.camel@schen9-DESK>
On Mon, Jan 20, 2014 at 05:24:28PM -0800, Tim Chen wrote:
> @@ -41,8 +47,11 @@ void mcs_spin_lock(struct mcs_spinlock **lock, struct mcs_spinlock *node)
>
> prev = xchg(lock, node);
> if (likely(prev == NULL)) {
> - /* Lock acquired */
> - node->locked = 1;
> + /* Lock acquired, don't need to set node->locked to 1
> + * as lock owner and other contenders won't check this value.
> + * If a debug mode is needed to audit lock status, then
> + * set node->locked value here.
> + */
Fail in comment style.
> return;
> }
> ACCESS_ONCE(prev->next) = node;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-21 10:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1390239879.git.tim.c.chen@linux.intel.com>
2014-01-21 1:24 ` [PATCH v8 0/6] MCS Lock: MCS lock code cleanup and optimizations Tim Chen
2014-01-21 1:24 ` [PATCH v8 1/6] MCS Lock: Barrier corrections Tim Chen
2014-01-21 1:24 ` [PATCH v8 2/6] MCS Lock: Restructure the MCS lock defines and locking Tim Chen
2014-01-21 1:24 ` [PATCH v8 3/6] MCS Lock: optimizations and extra comments Tim Chen
2014-01-21 10:17 ` Peter Zijlstra [this message]
2014-01-21 10:26 ` Peter Zijlstra
2014-01-21 17:31 ` Tim Chen
2014-01-21 21:01 ` Jason Low
2014-01-21 21:39 ` Tim Chen
2014-01-21 1:24 ` [PATCH v8 4/6] MCS Lock: Move mcs_lock/unlock function into its own Tim Chen
2014-01-21 10:19 ` Peter Zijlstra
2014-01-21 10:41 ` Ingo Molnar
2014-01-21 18:57 ` Tim Chen
2014-01-21 19:06 ` Ingo Molnar
2014-01-21 19:14 ` Tim Chen
2014-01-22 13:06 ` Ingo Molnar
2014-01-21 1:24 ` [PATCH v8 5/6] MCS Lock: allow architectures to hook in to contended Tim Chen
2014-01-21 10:12 ` Will Deacon
2014-01-21 1:24 ` [PATCH v8 6/6] MCS Lock: Allow architecture specific asm files to be used for contended case Tim Chen
2014-01-21 10:20 ` Peter Zijlstra
2014-01-21 10:45 ` Ingo Molnar
2014-01-21 10:59 ` Peter Zijlstra
2014-01-21 14:00 ` Ingo Molnar
2014-01-21 22:25 ` Tim Chen
2014-01-22 21:15 ` James Hogan
2014-01-22 21:19 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121101742.GR31570@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linaro.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=dave.hansen@intel.com \
--cc=davidlohr.bueso@hp.com \
--cc=figo1802@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter@hurleysoftware.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
--cc=walken@google.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox