From: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, liuj97@gmail.com,
santosh.shilimkar@ti.com, grygorii.strashko@ti.com,
iamjoonsoo.kim@lge.com, robin.m.holt@gmail.com,
tangchen@cn.fujitsu.com, yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable
Date: Tue, 21 Jan 2014 07:57:38 +0100 [thread overview]
Message-ID: <20140121075738.771d29b3@lilie> (raw)
In-Reply-To: <alpine.DEB.2.02.1401202214540.21729@chino.kir.corp.google.com>
Am Mon, 20 Jan 2014 22:16:33 -0800 (PST)
schrieb David Rientjes <rientjes@google.com>:
> Not sure why you don't just do a one line patch:
>
> - phys_addr_t size;
> + phys_addr_t size __maybe_unused;
> to fix it.
Just because I did not know that __maybe_unused thing.
Discussion of this fix seems to be obsolete because Andrew already took
the patch int the form he suggested: One #ifdef in the function with a
basic block declaring size once inside.
Regards
Philipp
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-21 6:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 11:32 [PATCH V5 0/3] mm/memblock: Excluded memory Philipp Hachtmann
2014-01-20 11:32 ` [PATCH V5 1/3] mm/nobootmem: Fix unused variable Philipp Hachtmann
2014-01-20 16:28 ` Robin Holt
2014-01-21 6:16 ` David Rientjes
2014-01-21 6:57 ` Philipp Hachtmann [this message]
2014-01-21 9:51 ` David Rientjes
2014-01-20 11:32 ` [PATCH V5 2/3] mm/memblock: Add support for excluded memory areas Philipp Hachtmann
2014-01-22 11:18 ` Philipp Hachtmann
2014-01-22 20:41 ` Andrew Morton
2014-01-22 15:27 ` Robin Holt
2014-01-20 11:32 ` [PATCH V5 3/3] mm/memblock: Cleanup and refactoring after addition of nomap Philipp Hachtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121075738.771d29b3@lilie \
--to=phacht@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=rientjes@google.com \
--cc=robin.m.holt@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=tangchen@cn.fujitsu.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox