From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v2 -mm] mm, oom: prefer thread group leaders for display purposes
Date: Fri, 17 Jan 2014 10:17:06 +0100 [thread overview]
Message-ID: <20140117091706.GA5356@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1401161447510.31228@chino.kir.corp.google.com>
On Thu 16-01-14 14:49:25, David Rientjes wrote:
> On Thu, 16 Jan 2014, Michal Hocko wrote:
>
> > > When two threads have the same badness score, it's preferable to kill the
> > > thread group leader so that the actual process name is printed to the
> > > kernel log rather than the thread group name which may be shared amongst
> > > several processes.
> >
> > I am not sure I understand this. Is this about ->comm? If yes then why
> > couldn't the group leader do PR_SET_NAME?
> >
>
> Both comm and pid, we only display thread group leaders in the tasklist
> dump of eligible processes, we want the killed message to specify from
> which process.
OK, that makes sense now. I didn't think about dump_tasks and
consistency in the output.
> You're suggesting a thread group leader do PR_SET_NAME of all its threads
> for readable oom killer output? Lol.
No, I am not suggesting anything. I was just asking why is group leader
different in this regards becasue changelog didn't tell it and I didn't
put it together with dump_tasks.
Thanks!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-01-17 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 2:40 [patch " David Rientjes
2014-01-16 7:05 ` Johannes Weiner
2014-01-16 7:45 ` David Rientjes
2014-01-16 7:46 ` [patch v2 " David Rientjes
2014-01-16 14:21 ` Michal Hocko
2014-01-16 22:49 ` David Rientjes
2014-01-17 9:17 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117091706.GA5356@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox