From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dave Hansen <dave@sr71.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, penberg@kernel.org,
cl@linux-foundation.org
Subject: Re: [RFC][PATCH 3/9] mm: page->pfmemalloc only used by slab/skb
Date: Thu, 16 Jan 2014 02:16:54 +0200 [thread overview]
Message-ID: <20140116001654.GB8456@node.dhcp.inet.fi> (raw)
In-Reply-To: <20140114180051.0181E467@viggo.jf.intel.com>
On Tue, Jan 14, 2014 at 10:00:51AM -0800, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> page->pfmemalloc does not deserve a spot in 'struct page'. It is
> only used transiently _just_ after a page leaves the buddy
> allocator.
>
> Instead of declaring a union, we move its functionality behind a
> few quick accessor functions. This way we could also much more
> easily audit that it is being used correctly in debugging
> scenarios. For instance, we could store a magic number in there
> which could never get reused as a page->index and check that the
> magic number exists in page_pfmemalloc().
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-16 0:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 18:00 [RFC][PATCH 0/9] re-shrink 'struct page' when SLUB is on Dave Hansen
2014-01-14 18:00 ` [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru Dave Hansen
2014-01-14 19:31 ` Christoph Lameter
2014-01-15 2:31 ` David Rientjes
2014-01-15 6:58 ` Dave Hansen
2014-01-15 7:16 ` David Rientjes
2014-01-16 0:11 ` Kirill A. Shutemov
2014-01-14 18:00 ` [RFC][PATCH 2/9] mm: slub: abstract out double cmpxchg option Dave Hansen
2014-01-14 19:49 ` Christoph Lameter
2014-01-14 21:41 ` Dave Hansen
2014-01-15 2:37 ` David Rientjes
2014-01-16 16:45 ` Christoph Lameter
2014-01-16 17:13 ` Dave Hansen
2014-01-14 18:00 ` [RFC][PATCH 3/9] mm: page->pfmemalloc only used by slab/skb Dave Hansen
2014-01-14 19:49 ` Christoph Lameter
2014-01-14 22:17 ` Dave Hansen
2014-01-15 2:45 ` David Rientjes
2014-01-16 0:16 ` Kirill A. Shutemov [this message]
2014-01-14 18:00 ` [RFC][PATCH 4/9] mm: slabs: reset page at free Dave Hansen
2014-01-15 2:48 ` David Rientjes
2014-01-16 18:35 ` Dave Hansen
2014-01-16 18:32 ` Christoph Lameter
2014-01-14 18:00 ` [RFC][PATCH 5/9] mm: rearrange struct page Dave Hansen
2014-01-16 0:20 ` Kirill A. Shutemov
2014-01-16 18:34 ` Christoph Lameter
2014-01-16 22:29 ` Dave Hansen
2014-01-17 14:58 ` Christoph Lameter
2014-01-14 18:01 ` [RFC][PATCH 6/9] mm: slub: rearrange 'struct page' fields Dave Hansen
2014-01-14 18:01 ` [RFC][PATCH 7/9] mm: slub: remove 'struct page' alignment restrictions Dave Hansen
2014-01-14 18:01 ` [RFC][PATCH 8/9] mm: slub: cleanups after code churn Dave Hansen
2014-01-14 18:01 ` [RFC][PATCH 9/9] mm: fix alignment checks on 32-bit Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116001654.GB8456@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox