From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by kanga.kvack.org (Postfix) with ESMTP id 091B26B0031 for ; Tue, 14 Jan 2014 10:48:06 -0500 (EST) Received: by mail-ea0-f176.google.com with SMTP id h14so3977004eaj.21 for ; Tue, 14 Jan 2014 07:48:06 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id d41si1882023eep.155.2014.01.14.07.48.00 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 14 Jan 2014 07:48:01 -0800 (PST) Date: Tue, 14 Jan 2014 15:47:56 +0000 From: Mel Gorman Subject: Re: [RFC PATCH] mm: thp: Add per-mm_struct flag to control THP Message-ID: <20140114154756.GE4963@suse.de> References: <1389383718-46031-1-git-send-email-athorlton@sgi.com> <20140110202310.GB1421@node.dhcp.inet.fi> <20140110220155.GD3066@sgi.com> <20140110222315.GA7931@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20140110222315.GA7931@node.dhcp.inet.fi> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Alex Thorlton , Andrea Arcangeli , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , "Kirill A. Shutemov" , Benjamin Herrenschmidt , Rik van Riel , Naoya Horiguchi , Oleg Nesterov , "Eric W. Biederman" , Andy Lutomirski , Al Viro , Kees Cook , linux-kernel@vger.kernel.org On Sat, Jan 11, 2014 at 12:23:15AM +0200, Kirill A. Shutemov wrote: > On Fri, Jan 10, 2014 at 04:01:55PM -0600, Alex Thorlton wrote: > > On Fri, Jan 10, 2014 at 10:23:10PM +0200, Kirill A. Shutemov wrote: > > > Do you know what cause the difference? I prefer to fix THP instead of > > > adding new knob to disable it. > > > > The issue is that when you touch 1 byte of an untouched, contiguous 2MB > > chunk, a THP will be handed out, and the THP will be stuck on whatever > > node the chunk was originally referenced from. If many remote nodes > > need to do work on that same chunk, they'll be making remote accesses. > > With THP disabled, 4K pages can be handed out to separate nodes as > > they're needed, greatly reducing the amount of remote accesses to > > memory. > > I think this problem *potentially* could be fixed by NUMA balancer. > (Although, I don't really know how balancer works...) > > If we see NUMA hint faults for addresses in different 4k pages inside huge > page from more then one node, we could split the huge page. > > Mel, is it possible? Do we collect enough info to make the decision? > Potentially the hinting faults can be used to decide whether to split or not but currently there is only limited information. You can detect if the last faulting process was on the same node but not if the faults were in different parts of the THP that would justify a split. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org