From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f176.google.com (mail-ie0-f176.google.com [209.85.223.176]) by kanga.kvack.org (Postfix) with ESMTP id 562046B0031 for ; Fri, 10 Jan 2014 17:02:00 -0500 (EST) Received: by mail-ie0-f176.google.com with SMTP id at1so5870783iec.35 for ; Fri, 10 Jan 2014 14:02:00 -0800 (PST) Received: from relay.sgi.com (relay3.sgi.com. [192.48.152.1]) by mx.google.com with ESMTP id f2si4994979iga.18.2014.01.10.14.01.58 for ; Fri, 10 Jan 2014 14:01:59 -0800 (PST) Date: Fri, 10 Jan 2014 16:01:55 -0600 From: Alex Thorlton Subject: Re: [RFC PATCH] mm: thp: Add per-mm_struct flag to control THP Message-ID: <20140110220155.GD3066@sgi.com> References: <1389383718-46031-1-git-send-email-athorlton@sgi.com> <20140110202310.GB1421@node.dhcp.inet.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140110202310.GB1421@node.dhcp.inet.fi> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , "Kirill A. Shutemov" , Benjamin Herrenschmidt , Rik van Riel , Naoya Horiguchi , Oleg Nesterov , "Eric W. Biederman" , Andy Lutomirski , Al Viro , Kees Cook , Andrea Arcangeli , linux-kernel@vger.kernel.org On Fri, Jan 10, 2014 at 10:23:10PM +0200, Kirill A. Shutemov wrote: > Do you know what cause the difference? I prefer to fix THP instead of > adding new knob to disable it. The issue is that when you touch 1 byte of an untouched, contiguous 2MB chunk, a THP will be handed out, and the THP will be stuck on whatever node the chunk was originally referenced from. If many remote nodes need to do work on that same chunk, they'll be making remote accesses. With THP disabled, 4K pages can be handed out to separate nodes as they're needed, greatly reducing the amount of remote accesses to memory. I give a bit better description here: https://lkml.org/lkml/2013/8/27/397 I had been looking into better ways to handle this issues, but after spinning through a few other ideas: - Per cpuset flag to control THP: https://lkml.org/lkml/2013/6/10/331 - Threshold to determine when to hand out THPs: https://lkml.org/lkml/2013/12/12/394 We've arrived back here. Andrea seemed to think that this is an acceptable approach to solve the problem, at least as a starting point: https://lkml.org/lkml/2013/12/17/397 I agree that we should, ideally, come up with a way to appropriately handle this problem in the kernel, but as of right now, it appears that that might be a rather large undertaking. - Alex -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org