From: Michal Hocko <mhocko@suse.cz>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Bob Liu <bob.liu@oracle.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: could you clarify mm/mempolicy: fix !vma in new_vma_page()
Date: Mon, 6 Jan 2014 12:24:22 +0100 [thread overview]
Message-ID: <20140106112422.GA27602@dhcp22.suse.cz> (raw)
Hi Wanpeng Li,
I have just noticed 11c731e81bb0 (mm/mempolicy: fix !vma in
new_vma_page()) and I am not sure I understand it. Your changelog claims
"
page_address_in_vma() may still return -EFAULT because of many other
conditions in it. As a result the while loop in new_vma_page() may end
with vma=NULL.
"
And the patch handles hugetlb case only. I was wondering what are those
"other conditions" that failed in the BUG_ON mentioned in the changelog?
Could you be more specific please?
Thanks!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-01-06 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 11:24 Michal Hocko [this message]
2014-01-06 12:45 ` Bob Liu
2014-01-06 14:18 ` Michal Hocko
2014-01-07 4:26 ` Wanpeng Li
2014-01-07 4:34 ` Wanpeng Li
2014-01-07 8:34 ` Michal Hocko
2014-01-07 5:29 ` Bob Liu
2014-01-07 10:22 ` Michal Hocko
2014-01-07 17:30 ` Michal Hocko
2014-01-08 0:56 ` Bob Liu
2014-01-08 10:08 ` Michal Hocko
2014-01-08 12:09 ` Bob Liu
2014-01-08 12:42 ` Michal Hocko
2014-01-08 13:10 ` Bob Liu
2014-01-08 13:49 ` Michal Hocko
2014-01-08 13:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106112422.GA27602@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=bob.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox