From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by kanga.kvack.org (Postfix) with ESMTP id 065AF6B003B for ; Fri, 20 Dec 2013 06:13:09 -0500 (EST) Received: by mail-ee0-f49.google.com with SMTP id c41so977993eek.22 for ; Fri, 20 Dec 2013 03:13:09 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id h45si8269104eeo.46.2013.12.20.03.13.08 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 20 Dec 2013 03:13:08 -0800 (PST) Date: Fri, 20 Dec 2013 11:13:03 +0000 From: Mel Gorman Subject: Re: [PATCH 0/4] Fix ebizzy performance regression due to X86 TLB range flush v2 Message-ID: <20131220111303.GZ11295@suse.de> References: <1386964870-6690-1-git-send-email-mgorman@suse.de> <20131215155539.GM11295@suse.de> <20131216102439.GA21624@gmail.com> <20131216125923.GS11295@suse.de> <20131216134449.GA3034@gmail.com> <20131217092124.GV11295@suse.de> <20131217110051.GA27701@gmail.com> <20131219142405.GM11295@suse.de> <20131219164925.GA29546@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20131219164925.GA29546@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Linus Torvalds , Alex Shi , Thomas Gleixner , Andrew Morton , Fengguang Wu , H Peter Anvin , Linux-X86 , Linux-MM , LKML , Peter Zijlstra On Thu, Dec 19, 2013 at 05:49:25PM +0100, Ingo Molnar wrote: > > * Mel Gorman wrote: > > > [...] > > > > Because we lack data on TLB range flush distributions I think we > > should still go with the conservative choice for the TLB flush > > shift. The worst case is really bad here and it's painfully obvious > > on ebizzy. > > So I'm obviously much in favor of this - I'd in fact suggest making > the conservative choice on _all_ CPU models that have aggressive TLB > range values right now, because frankly the testing used to pick those > values does not look all that convincing to me. > I think the choices there are already reasonably conservative. I'd be reluctant to support merging a patch that made a choice on all CPU models without having access to the machines to run tests on. I don't see the Intel people volunteering to do the necessary testing. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org