linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tim Hockin <thockin@hockin.org>
Cc: Michal Hocko <mhocko@suse.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Li Zefan <lizefan@huawei.com>, Tejun Heo <tj@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
	Pekka Enberg <penberg@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 7/8] mm, memcg: allow processes handling oom notifications to access reserves
Date: Sat, 7 Dec 2013 14:06:53 -0500	[thread overview]
Message-ID: <20131207190653.GI21724@cmpxchg.org> (raw)
In-Reply-To: <CAAAKZwvanMiz8QZVOU0-SUKYzqcaJAXn0HxYs5+=Zakmnbcfbg@mail.gmail.com>

On Sat, Dec 07, 2013 at 10:12:19AM -0800, Tim Hockin wrote:
> You more or less described the fundamental change - a score per memcg, with
> a recursive OOM killer which evaluates scores between siblings at the same
> level.
> 
> It gets a bit complicated because we have need if wider scoring ranges than
> are provided by default

If so, I'm sure you can make a convincing case to widen the internal
per-task score ranges.  The per-memcg score ranges have not even be
defined, so this is even easier.

> and because we score PIDs against mcgs at a given scope.

You are describing bits of a solution, not a problem.  And I can't
possibly infer a problem from this.

> We also have some tiebreaker heuristic (age).

Either periodically update the per-memcg score from userspace or
implement this in the kernel.  We have considered CPU usage
history/runtime etc. in the past when picking an OOM victim task.

But I'm again just speculating what your problem is, so this may or
may not be a feasible solution.

> We also have a handful of features that depend on OOM handling like the
> aforementioned automatically growing and changing the actual OOM score
> depending on usage in relation to various thresholds ( e.g. we sold you X,
> and we allow you to go over X but if you do, your likelihood of death in
> case of system OOM goes up.

You can trivially monitor threshold events from userspace with the
existing infrastructure and accordingly update the per-memcg score.

> Do you really want us to teach the kernel policies like this?  It would be
> way easier to do and test in userspace.

Maybe.  Providing fragments of your solution is not an efficient way
to communicate the problem.  And you have to sell the problem before
anybody can be expected to even consider your proposal as one of the
possible solutions.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-12-07 19:07 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 13:14 user defined OOM policies Michal Hocko
2013-11-19 13:40 ` Michal Hocko
2013-11-20  8:02   ` David Rientjes
2013-11-20 15:22     ` Michal Hocko
2013-11-20 17:14       ` Luigi Semenzato
2013-11-21  3:36         ` David Rientjes
2013-11-21  7:03           ` Luigi Semenzato
2013-11-22 18:08             ` Johannes Weiner
2013-11-28 11:36               ` Michal Hocko
2013-11-26  1:29             ` David Rientjes
2013-11-28 11:42               ` Michal Hocko
2013-12-02 23:09                 ` David Rientjes
2013-11-21  3:33       ` David Rientjes
2013-11-28 11:54         ` Michal Hocko
2013-12-02 23:07           ` David Rientjes
2013-12-04  5:19             ` [patch 1/8] fork: collapse copy_flags into copy_process David Rientjes
2013-12-04  5:19               ` [patch 2/8] mm, mempolicy: rename slab_node for clarity David Rientjes
2013-12-04 15:21                 ` Christoph Lameter
2013-12-04  5:20               ` [patch 3/8] mm, mempolicy: remove per-process flag David Rientjes
2013-12-04 15:24                 ` Christoph Lameter
2013-12-05  0:53                   ` David Rientjes
2013-12-05 19:05                     ` Christoph Lameter
2013-12-05 23:53                       ` David Rientjes
2013-12-06 14:46                         ` Christoph Lameter
2013-12-04  5:20               ` [patch 4/8] mm, memcg: add tunable for oom reserves David Rientjes
2013-12-04  5:20               ` [patch 5/8] res_counter: remove interface for locked charging and uncharging David Rientjes
2013-12-04  5:20               ` [patch 6/8] res_counter: add interface for maximum nofail charge David Rientjes
2013-12-04  5:20               ` [patch 7/8] mm, memcg: allow processes handling oom notifications to access reserves David Rientjes
2013-12-04  5:45                 ` Johannes Weiner
2013-12-05  1:49                   ` David Rientjes
2013-12-05  2:50                     ` Tejun Heo
2013-12-05 23:49                       ` David Rientjes
2013-12-06 17:34                         ` Johannes Weiner
2013-12-07 16:38                           ` Tim Hockin
2013-12-07 17:40                             ` Johannes Weiner
2013-12-07 18:12                               ` Tim Hockin
2013-12-07 19:06                                 ` Johannes Weiner [this message]
2013-12-07 21:04                                   ` Tim Hockin
2013-12-06 19:01                         ` Tejun Heo
2013-12-09 20:10                           ` David Rientjes
2013-12-09 22:37                             ` Johannes Weiner
2013-12-10 21:50                             ` Tejun Heo
2013-12-10 23:55                               ` David Rientjes
2013-12-11  9:49                                 ` Mel Gorman
2013-12-11 12:42                                 ` Tejun Heo
2013-12-12  5:37                                   ` Tim Hockin
2013-12-12 14:21                                     ` Tejun Heo
2013-12-12 16:32                                       ` Michal Hocko
2013-12-12 16:37                                         ` Tejun Heo
2013-12-12 18:42                                       ` Tim Hockin
2013-12-12 19:23                                         ` Tejun Heo
2013-12-13  0:23                                           ` Tim Hockin
2013-12-13 11:47                                             ` Tejun Heo
2013-12-04  5:20               ` [patch 8/8] mm, memcg: add memcg oom reserve documentation David Rientjes
2013-11-20 17:25     ` user defined OOM policies Vladimir Murzin
2013-11-20 17:21   ` Vladimir Murzin
2013-11-20 17:33     ` Michal Hocko
2013-11-21  3:38       ` David Rientjes
2013-11-21 17:13         ` Michal Hocko
2013-11-26  1:36           ` David Rientjes
2013-11-22  7:28       ` Vladimir Murzin
2013-11-22 13:18         ` Michal Hocko
2013-11-20  7:50 ` David Rientjes
2013-11-22  0:19 ` Jörn Engel
2013-11-26  1:31   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131207190653.GI21724@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cl@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=thockin@hockin.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox