From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f50.google.com (mail-bk0-f50.google.com [209.85.214.50]) by kanga.kvack.org (Postfix) with ESMTP id 50E3E6B0035 for ; Fri, 22 Nov 2013 19:09:29 -0500 (EST) Received: by mail-bk0-f50.google.com with SMTP id e11so1034997bkh.37 for ; Fri, 22 Nov 2013 16:09:28 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTP id l9si6342817bko.29.2013.11.22.16.09.27 for ; Fri, 22 Nov 2013 16:09:27 -0800 (PST) Date: Sat, 23 Nov 2013 00:09:24 +0000 From: Mel Gorman Subject: Re: BUG: mm, numa: test segfaults, only when NUMA balancing is on Message-ID: <20131123000924.GC5285@suse.de> References: <20131104200346.GA3066@sgi.com> <20131106131048.GC4877@suse.de> <20131107214838.GY3066@sgi.com> <20131108112054.GB5040@suse.de> <20131108221329.GD4236@sgi.com> <20131112212902.GA4725@sgi.com> <20131115000901.GB26002@suse.de> <20131115144504.GE26002@suse.de> <20131122212807.GR3062@sgi.com> <20131122230524.GB5285@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20131122230524.GB5285@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Alex Thorlton Cc: Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Nov 22, 2013 at 11:05:24PM +0000, Mel Gorman wrote: > On Fri, Nov 22, 2013 at 03:28:07PM -0600, Alex Thorlton wrote: > > > If the warning added by that patch does *not* trigger than can you also > > > test this patch? It removes the barriers which should not be necessary > > > and takes a reference tot he page before waiting on the lock. The > > > previous version did not take the reference because otherwise the > > > WARN_ON could not distinguish between a migration waiter and a surprise > > > gup. > > > > Sorry for the delay; been a bit busy. I tested both of these patches on > > top of this one (separately, of course): > > > > http://www.spinics.net/lists/linux-mm/msg63919.html > > > > I think that's the one you were referring to, if not send me a pointer > > to the correct one and I'll give it another shot. Both patches still > > segfaulted, so it doesn't appear that either of these solved the > > problem. > > I see. Does THP have to be enabled or does it segfault even with THP > disabled? > On a semi-related note, is the large machine doing anything with xpmem or anything that depends on MMU notifiers to work properly? I noted while looking at this that THP migration is not invalidating pages which might be confusing a driver depending on it. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org