From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id 302486B0035 for ; Fri, 22 Nov 2013 17:30:51 -0500 (EST) Received: by mail-pd0-f170.google.com with SMTP id g10so1849291pdj.1 for ; Fri, 22 Nov 2013 14:30:50 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id iz5si976015pbd.2.2013.11.22.14.30.49 for ; Fri, 22 Nov 2013 14:30:49 -0800 (PST) Date: Fri, 22 Nov 2013 14:30:47 -0800 From: Andrew Morton Subject: Re: [PATCH] mmzone.h: constify some zone access functions Message-Id: <20131122143047.51b4fbe7aa227b8e37908106@linux-foundation.org> In-Reply-To: <20131122120106.4c372847@redhat.com> References: <20131122120106.4c372847@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Luiz Capitulino Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com On Fri, 22 Nov 2013 12:01:06 -0500 Luiz Capitulino wrote: > Signed-off-by: Luiz capitulino > --- > include/linux/mmzone.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index bd791e4..5e202d6 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -560,12 +560,12 @@ static inline bool zone_spans_pfn(const struct zone *zone, unsigned long pfn) > return zone->zone_start_pfn <= pfn && pfn < zone_end_pfn(zone); > } > > -static inline bool zone_is_initialized(struct zone *zone) > +static inline bool zone_is_initialized(const struct zone *zone) > { > return !!zone->wait_table; > } > > -static inline bool zone_is_empty(struct zone *zone) > +static inline bool zone_is_empty(const struct zone *zone) > { > return zone->spanned_pages == 0; > } > @@ -843,7 +843,7 @@ unsigned long __init node_memmap_size_bytes(int, unsigned long, unsigned long); > */ > #define zone_idx(zone) ((zone) - (zone)->zone_pgdat->node_zones) > > -static inline int populated_zone(struct zone *zone) > +static inline int populated_zone(const struct zone *zone) > { > return (!!zone->present_pages); > } hm, why? I counted ten similarly constifyable functions in mm.h and stopped only 1/4 of the way through. What's so special about these three? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org