linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Expose sysctls for enabling slab/file_cache interleaving
Date: Tue, 19 Nov 2013 19:42:00 +0100	[thread overview]
Message-ID: <20131119184200.GD29695@two.firstfloor.org> (raw)
In-Reply-To: <20131119104203.GB18872@dhcp22.suse.cz>

On Tue, Nov 19, 2013 at 11:42:03AM +0100, Michal Hocko wrote:
> On Mon 18-11-13 16:50:22, Andi Kleen wrote:
> [...]
> > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> > index cc1b01c..10966f5 100644
> > --- a/include/linux/cpuset.h
> > +++ b/include/linux/cpuset.h
> > @@ -72,12 +72,14 @@ extern int cpuset_slab_spread_node(void);
> >  
> >  static inline int cpuset_do_page_mem_spread(void)
> >  {
> > -	return current->flags & PF_SPREAD_PAGE;
> > +	return (current->flags & PF_SPREAD_PAGE) ||
> > +		sysctl_spread_file_cache;
> >  }
> 
> But this might break applications that explicitly opt out from
> spreading.

What do you mean? There's no such setting at the moment.

They can only enable it.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-11-19 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19  0:50 Andi Kleen
2013-11-19 10:42 ` Michal Hocko
2013-11-19 18:42   ` Andi Kleen [this message]
2013-11-19 19:11     ` Michal Hocko
2013-11-19 20:13       ` Andi Kleen
2013-11-19 21:21         ` Michal Hocko
2013-11-19 21:49           ` Andi Kleen
2013-11-20  5:49             ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131119184200.GD29695@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox