From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] mm: create a separate slab for page->ptl allocation
Date: Mon, 18 Nov 2013 14:04:17 +1100 [thread overview]
Message-ID: <20131118140417.9e8aee3f72a006ec3c6c6000@canb.auug.org.au> (raw)
In-Reply-To: <CAMuHMdV33zBfsztXGsSv5YO+r4c2Fxh+0tH7togtS7EjdhDXeA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
Hi Geert,
On Sat, 16 Nov 2013 21:43:32 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Thu, Nov 7, 2013 at 3:14 PM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
>
> > +static inline void pgtable_init(void)
> > +{
> > + ptlock_cache_init();
> > + pgtable_cache_init();
> > +}
>
> sparc64defconfig:
>
> include/linux/mm.h:1391:2: error: implicit declaration of function
> 'pgtable_cache_init' [-Werror=implicit-function-declaration]
> arch/sparc/include/asm/pgtable_64.h:978:13: error: conflicting types
> for 'pgtable_cache_init' [-Werror]
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/10040274/
>
> Has this been in -next?
No, it hasn't :-(
> Probably it needs <asm/pgtable.h>.
Actually it is because on sparc64, asm/tlbflush_64.h includes linux/mm.h
(and asm/pgtable.h -> asm/pgtable_64.h -> asm/tlbflush.h ->
asm/tlbflush_64.h)
(see my other error report and I have reverted that commit from
linux-next today.)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-18 3:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 14:14 [PATCH 1/2] mm: Properly separate the bloated ptl from the regular case Kirill A. Shutemov
2013-11-07 14:14 ` [PATCH 2/2] mm: create a separate slab for page->ptl allocation Kirill A. Shutemov
2013-11-16 20:43 ` Geert Uytterhoeven
2013-11-18 3:04 ` Stephen Rothwell [this message]
2013-11-15 22:01 ` [PATCH 1/2] mm: Properly separate the bloated ptl from the regular case Tony Luck
2013-11-15 22:09 ` Tony Luck
2013-11-15 23:15 ` Kirill A. Shutemov
2013-11-15 23:33 ` Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118140417.9e8aee3f72a006ec3c6c6000@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox