From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Waiman Long <waiman.long@hp.com>, Arnd Bergmann <arnd@arndb.de>,
Rik van Riel <riel@redhat.com>,
Aswin Chandramouleeswaran <aswin@hp.com>,
"Paul E.McKenney" <paulmck@linux.vnet.ibm.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
"Figo. zhang" <figo1802@gmail.com>,
linux-arch@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
George Spelvin <linux@horizon.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Michel Lespinasse <walken@google.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Hurley <peter@hurleysoftware.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Alex Shi <alex.shi@linaro.org>,
linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hp.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@intel.com>,
Matthew R Wilcox <matthew.r.wilcox@intel.com>,
Will Deacon <will.deacon@arm.com>,
Davidlohr Bueso <davidlohr.bueso@hp.com>
Subject: Re: [PATCH v3 3/5] MCS Lock: Barrier corrections
Date: Thu, 7 Nov 2013 09:25:41 +0100 [thread overview]
Message-ID: <20131107082541.GA32542@gmail.com> (raw)
In-Reply-To: <CA+55aFzMcEudpr2rXdaD7O70=iMEYUKsjB5tGy=zFKTLiyhXgw@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> I don't necessarily mind the factoring out, I just think it needs to be
> really solid and clear if - and *before* - we do this. [...]
Okay, agreed.
> [...] We do *not* want to factor out some half-arsed implementation and
> then have later patches to fix up the crud. Nor when multiple different
> locks then use that common code.
>
> So I think it needs to be *clearly* great code before it gets factored
> out. Because before it is great code, it should not be shared with
> anything else.
Ok, we'll go through it with a fine comb and I won't rush merging it.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-07 8:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1383771175.git.tim.c.chen@linux.intel.com>
2013-11-06 21:36 ` [PATCH v3 0/4] MCS Lock: MCS lock code cleanup and optimizations Tim Chen
2013-11-06 21:41 ` Davidlohr Bueso
2013-11-06 23:55 ` Tim Chen
2013-11-06 21:42 ` H. Peter Anvin
2013-11-06 21:59 ` Michel Lespinasse
2013-11-06 21:37 ` [PATCH v3 1/5] MCS Lock: Restructure the MCS lock defines and locking code into its own file Tim Chen
2013-11-06 21:37 ` [PATCH v3 2/5] MCS Lock: optimizations and extra comments Tim Chen
2013-11-06 21:47 ` Tim Chen
2013-11-06 21:37 ` [PATCH v3 3/5] MCS Lock: Barrier corrections Tim Chen
2013-11-07 1:39 ` Linus Torvalds
2013-11-07 4:29 ` Waiman Long
2013-11-07 8:13 ` Ingo Molnar
2013-11-07 8:22 ` Linus Torvalds
2013-11-07 8:25 ` Ingo Molnar [this message]
2013-11-07 9:55 ` Michel Lespinasse
2013-11-07 12:06 ` Linus Torvalds
2013-11-07 12:50 ` Michel Lespinasse
2013-11-07 14:31 ` Paul E. McKenney
2013-11-07 19:59 ` Michel Lespinasse
2013-11-07 21:15 ` Tim Chen
2013-11-07 22:21 ` Peter Zijlstra
2013-11-07 22:43 ` Michel Lespinasse
2013-11-08 1:16 ` Tim Chen
2013-11-06 21:37 ` [PATCH v3 4/5] MCS Lock: Make mcs_spinlock.h includable in other files Tim Chen
2013-11-06 21:41 ` Tim Chen
2013-11-06 21:37 ` [PATCH v3 5/5] MCS Lock: Allow architecture specific memory barrier in lock/unlock Tim Chen
2013-11-06 21:42 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107082541.GA32542@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linaro.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=dave.hansen@intel.com \
--cc=davidlohr.bueso@hp.com \
--cc=figo1802@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter@hurleysoftware.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
--cc=walken@google.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox