From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] mm: create a separate slab for page->ptl allocation
Date: Tue, 5 Nov 2013 16:43:51 -0800 [thread overview]
Message-ID: <20131105164351.b2c63109.akpm@linux-foundation.org> (raw)
In-Reply-To: <20131105231310.GE20167@shutemov.name>
On Wed, 6 Nov 2013 01:13:11 +0200 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> > Really the function shouldn't exist in this case. It is __init so the
> > sin is not terrible, but can this be arranged?
>
> I would like to get rid of __ptlock_alloc()/__ptlock_free() too, but I
> don't see a way within C: we need to know sizeof(spinlock_t) on
> preprocessor stage.
>
> We can have a hack on kbuild level: write small helper program to find out
> sizeof(spinlock_t) before start building and turn it into define.
> But it's overkill from my POV. And cross-compilation will be a fun.
Yes, it doesn't seem worth the fuss. The compiler will remove all this
code anyway, so for example ptlock_cache_init() becomes an empty function.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-06 0:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 11:53 Kirill A. Shutemov
2013-10-22 12:55 ` Fengguang Wu
2013-11-04 10:42 ` Kirill A. Shutemov
2013-11-05 23:01 ` Andrew Morton
2013-11-05 22:42 ` Kirill A. Shutemov
2013-11-05 23:56 ` Andrew Morton
2013-11-05 23:13 ` Kirill A. Shutemov
2013-11-06 0:43 ` Andrew Morton [this message]
2013-11-06 9:31 ` Peter Zijlstra
2013-11-06 11:18 ` Peter Zijlstra
2013-11-06 13:31 ` lockref: Use bloated_spinlocks to avoid explicit config dependencies Kirill A. Shutemov
2013-11-06 14:32 ` Peter Zijlstra
2013-11-06 13:21 ` [PATCH] mm: create a separate slab for page->ptl allocation Kirill A. Shutemov
2013-11-06 14:30 ` Peter Zijlstra
2013-11-06 10:34 ` Will Deacon
2013-11-06 10:49 ` Geert Uytterhoeven
2013-11-06 11:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105164351.b2c63109.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox