From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>,
cl@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] percpu: little optimization on calculating pcpu_unit_size
Date: Mon, 28 Oct 2013 10:43:01 +0800 [thread overview]
Message-ID: <20131028024301.GB15642@weiyang.vnet.ibm.com> (raw)
In-Reply-To: <20131027123634.GL14934@mtj.dyndns.org>
On Sun, Oct 27, 2013 at 08:36:34AM -0400, Tejun Heo wrote:
>On Mon, Oct 21, 2013 at 04:58:13PM +0800, Wei Yang wrote:
>> pcpu_unit_size exactly equals to ai->unit_size.
>>
>> This patch assign this value instead of calculating from pcpu_unit_pages. Also
>> it reorder them to make it looks more friendly to audience.
>
>Ditto. I'd rather not change unless this is clearly better.
This one change an assignement to a shift, which in my mind is a little
faster.
Well, this is just executed once during the boot time, not a big deal.
>
>Thanks.
>
>--
>tejun
--
Richard Yang
Help you, Help me
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-28 2:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 8:58 [PATCH 1/3] percpu: stop the loop when a cpu belongs to a new group Wei Yang
2013-10-21 8:58 ` [PATCH 2/3] percpu: merge two loops when setting up group info Wei Yang
2013-10-27 12:35 ` Tejun Heo
2013-10-28 2:37 ` Wei Yang
2013-10-21 8:58 ` [PATCH 3/3] percpu: little optimization on calculating pcpu_unit_size Wei Yang
2013-10-27 12:36 ` Tejun Heo
2013-10-28 2:43 ` Wei Yang [this message]
2013-10-27 12:30 ` [PATCH 1/3] percpu: stop the loop when a cpu belongs to a new group Tejun Heo
2013-10-28 3:00 ` Wei Yang
2013-10-28 11:31 ` Tejun Heo
2013-10-28 15:17 ` Wei Yang
2013-11-20 3:00 ` Wei Yang
2013-11-20 5:51 ` Tejun Heo
2013-11-20 6:58 ` Wei Yang
2013-11-22 23:04 ` Tejun Heo
2013-11-24 1:48 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028024301.GB15642@weiyang.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox