From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by kanga.kvack.org (Postfix) with ESMTP id 1FD926B0031 for ; Fri, 11 Oct 2013 11:54:58 -0400 (EDT) Received: by mail-pb0-f46.google.com with SMTP id rq2so4379064pbb.5 for ; Fri, 11 Oct 2013 08:54:57 -0700 (PDT) Date: Fri, 11 Oct 2013 08:54:54 -0700 From: Greg KH Subject: Re: [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL Message-ID: <20131011155454.GA32305@kroah.com> References: <52579C69.1080304@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52579C69.1080304@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: Yasuaki Ishimatsu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, toshi.kani@hp.com, sjenning@linux.vnet.ibm.com On Fri, Oct 11, 2013 at 03:36:25PM +0900, Yasuaki Ishimatsu wrote: > When inserting a wrong value to /sys/devices/system/memory/memoryX/state file, > following messages are shown. And device_hotplug_lock is never released. > > ================================================ > [ BUG: lock held when returning to user space! ] > 3.12.0-rc4-debug+ #3 Tainted: G W > ------------------------------------------------ > bash/6442 is leaving the kernel with locks still held! > 1 lock held by bash/6442: > #0: (device_hotplug_lock){+.+.+.}, at: [] lock_device_hotplug_sysfs+0x15/0x50 > > This issue was introdued by commit fa2be40 (drivers: base: use standard > device online/offline for state change). > > This patch releases device_hotplug_lcok when store_mem_state returns EINVAL. > > Signed-off-by: Yasuaki Ishimatsu > CC: Toshi Kani > CC: Seth Jennings > CC: Greg Kroah-Hartman Is this needed in 3.12-final, and possibly older kernel releases as well (3.10, 3.11, etc.)? Or is it ok for 3.13? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org