From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id A97C46B0037 for ; Mon, 7 Oct 2013 19:54:15 -0400 (EDT) Received: by mail-pd0-f172.google.com with SMTP id z10so7887737pdj.31 for ; Mon, 07 Oct 2013 16:54:15 -0700 (PDT) Date: Mon, 7 Oct 2013 16:54:11 -0700 From: Andrew Morton Subject: Re: [PATCH 1/2] mm/page_alloc.c: Implement an empty get_pfn_range_for_nid Message-Id: <20131007165411.92370f7f6119decee7fbbcba@linux-foundation.org> In-Reply-To: <52504CF8.6000708@gmail.com> References: <52504CF8.6000708@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Zhang Yanfei Cc: Linux MM , "linux-kernel@vger.kernel.org" On Sun, 06 Oct 2013 01:31:36 +0800 Zhang Yanfei wrote: > From: Zhang Yanfei > > Implement an empty get_pfn_range_for_nid for !CONFIG_HAVE_MEMBLOCK_NODE_MAP, > so that we could remove the #ifdef in free_area_init_node. > > ... > > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4566,6 +4566,11 @@ static unsigned long __meminit zone_absent_pages_in_node(int nid, > } > > #else /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */ > +void __meminit get_pfn_range_for_nid(unsigned int nid, > + unsigned long *ignored, unsigned long *ignored) > +{ > +} > + > static inline unsigned long __meminit zone_spanned_pages_in_node(int nid, > unsigned long zone_type, > unsigned long node_start_pfn, > @@ -4871,9 +4876,7 @@ void __paginginit free_area_init_node(int nid, unsigned long *zones_size, > pgdat->node_id = nid; > pgdat->node_start_pfn = node_start_pfn; > init_zone_allows_reclaim(nid); > -#ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > -#endif > calculate_node_totalpages(pgdat, start_pfn, end_pfn, > zones_size, zholes_size); Dunno, really. This will make the kernel a tiny bit larger by generating an out-of-line empty function which nobody calls. This could be fixed by making this static inline, but it's strange to have one version of get_pfn_range_for_nid() static inline and the other global, uninlined. Is it worth adding a few bytes to vmlinux just to make the source a little tidier? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org