From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id 78D8E6B0037 for ; Mon, 7 Oct 2013 19:09:12 -0400 (EDT) Received: by mail-pd0-f179.google.com with SMTP id v10so7783122pde.24 for ; Mon, 07 Oct 2013 16:09:12 -0700 (PDT) Date: Mon, 7 Oct 2013 16:09:07 -0700 From: Andrew Morton Subject: Re: [PATCHv5 00/11] split page table lock for PMD tables Message-Id: <20131007160907.3a4aca3e7eae404767ed3a8e@linux-foundation.org> In-Reply-To: <1381154053-4848-1-git-send-email-kirill.shutemov@linux.intel.com> References: <1381154053-4848-1-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Alex Thorlton , Ingo Molnar , Naoya Horiguchi , "Eric W . Biederman" , "Paul E . McKenney" , Al Viro , Andi Kleen , Andrea Arcangeli , Dave Hansen , Dave Jones , David Howells , Frederic Weisbecker , Johannes Weiner , Kees Cook , Mel Gorman , Michael Kerrisk , Oleg Nesterov , Peter Zijlstra , Rik van Riel , Robin Holt , Sedat Dilek , Srikar Dronamraju , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Mon, 7 Oct 2013 16:54:02 +0300 "Kirill A. Shutemov" wrote: > Alex Thorlton noticed that some massively threaded workloads work poorly, > if THP enabled. This patchset fixes this by introducing split page table > lock for PMD tables. hugetlbfs is not covered yet. > > This patchset is based on work by Naoya Horiguchi. I think I'll summarise the results thusly: : THP off, v3.12-rc2: 18.059261877 seconds time elapsed : THP off, patched: 16.768027318 seconds time elapsed : : THP on, v3.12-rc2: 42.162306788 seconds time elapsed : THP on, patched: 8.397885779 seconds time elapsed : : HUGETLB, v3.12-rc2: 47.574936948 seconds time elapsed : HUGETLB, patched: 19.447481153 seconds time elapsed What sort of machines are we talking about here? Can mortals expect to see such results on their hardware, or is this mainly on SGI nuttyware? I'm seeing very few reviewed-by's and acked-by's in here, which is a bit surprising and disappointing for a large patchset at v5. Are you sure none were missed? The new code is enabled only for x86. Why is this? What must arch maintainers do to enable it? Have you any particular suggestions, warnings etc to make their lives easier? I assume the patchset won't damage bisectability? If our bisecter has only the first eight patches applied, the fact that CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK cannot be enabled protects from failures? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org