From: Andrew Morton <akpm@linux-foundation.org>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
iamjoonsoo.kim@lge.com, rientjes@google.com,
zhangyanfei@cn.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice
Date: Mon, 23 Sep 2013 16:18:05 -0700 [thread overview]
Message-ID: <20130923161805.4b4b570241224b673e5c3b1b@linux-foundation.org> (raw)
In-Reply-To: <5237946f.4815440a.094e.ffff8c29SMTPIN_ADDED_BROKEN@mx.google.com>
On Tue, 17 Sep 2013 07:29:41 +0800 Wanpeng Li <liwanp@linux.vnet.ibm.com> wrote:
> >> to set it again in __vmalloc_area_node.
> >>
> >> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> >> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
> >> ---
> >> mm/vmalloc.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> >> index 1074543..d78d117 100644
> >> --- a/mm/vmalloc.c
> >> +++ b/mm/vmalloc.c
> >> @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
> >> pages = kmalloc_node(array_size, nested_gfp, node);
> >> }
> >> area->pages = pages;
> >> - area->caller = caller;
> >> if (!area->pages) {
> >> remove_vm_area(area->addr);
> >> kfree(area);
> >
> >Then, __vmalloc_area_node() no longer need "caller" argument. It can use area->caller instead.
> >
>
> Thanks for pointing out, I will update it in next version.
I've seen so many versions of this patchset that my head has spun right
off. I'm not at all confident that I have the latest version and I'm
certainly not confident that I've kept up with the ack/nack trail.
So I think I'll drop everything and will await that "next version".
Please be careful to Cc everyone who was involved and that the
acked/reviewed-by paperwork is up to date.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-23 23:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 23:45 Wanpeng Li
2013-09-14 23:45 ` [RESEND PATCH v5 2/4] mm/vmalloc: revert "mm/vmalloc.c: emit the failure message before return" Wanpeng Li
2013-09-16 20:15 ` KOSAKI Motohiro
2013-09-16 23:41 ` Wanpeng Li
2013-09-16 23:41 ` Wanpeng Li
[not found] ` <5237971b.4c19310a.2b36.7d41SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-17 5:39 ` KOSAKI Motohiro
2013-09-17 6:28 ` Wanpeng Li
2013-09-17 6:28 ` Wanpeng Li
2013-09-14 23:45 ` [RESEND PATCH v5 3/4] mm/vmalloc: revert "mm/vmalloc.c: check VM_UNINITIALIZED flag in s_show instead of show_numa_info" Wanpeng Li
2013-09-16 21:23 ` KOSAKI Motohiro
2013-09-17 0:18 ` Wanpeng Li
2013-09-17 0:18 ` Wanpeng Li
[not found] ` <52379fe8.c250e00a.63fd.ffff8ccdSMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-17 5:44 ` KOSAKI Motohiro
2013-09-17 6:06 ` Wanpeng Li
2013-09-17 6:06 ` Wanpeng Li
2013-09-14 23:45 ` [RESEND PATCH v5 4/4] mm/vmalloc: fix show vmap_area information race with vmap_area tear down Wanpeng Li
2013-09-16 21:27 ` KOSAKI Motohiro
2013-09-16 23:25 ` Wanpeng Li
2013-09-16 23:25 ` Wanpeng Li
2013-09-16 19:52 ` [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice KOSAKI Motohiro
2013-09-16 23:29 ` Wanpeng Li
2013-09-16 23:29 ` Wanpeng Li
[not found] ` <5237946f.4815440a.094e.ffff8c29SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-23 23:18 ` Andrew Morton [this message]
2013-09-24 0:01 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923161805.4b4b570241224b673e5c3b1b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=rientjes@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox