linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Hillf Danton" <dhillf@sina.com>
To: linux-mm <linux-mm@kvack.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jan Kara <jack@suse.cz>, Hillf Danton <dhillf@gmail.com>,
	Hillf Danton <dhillf@sina.com>
Subject: [patch] filemap: add missing unlock_page
Date: Mon, 09 Sep 2013 16:18:22 +0800	[thread overview]
Message-ID: <20130909081822.8D4DF428001@webmail.sinamail.sina.com.cn> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GBK, Size: 462 bytes --]

Unlock and release page before returning error.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/mm/filemap.c	Mon Sep  9 15:51:28 2013
+++ b/mm/filemap.c	Mon Sep  9 15:52:54 2013
@@ -1844,6 +1844,7 @@ retry:
 	}
 	err = filler(data, page);
 	if (err < 0) {
+		unlock_page(page);
 		page_cache_release(page);
 		return ERR_PTR(err);
 	}
--N‹§²æìr¸›zǧu©ž²Æ {\b­†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨­è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ

             reply	other threads:[~2013-09-09  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09  8:18 Hillf Danton [this message]
2013-09-09  7:51 ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130909081822.8D4DF428001@webmail.sinamail.sina.com.cn \
    --to=dhillf@sina.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhillf@gmail.com \
    --cc=hughd@google.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox