From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Rik van Riel <riel@redhat.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Jiri Kosina <jkosina@suse.cz>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap
Date: Thu, 29 Aug 2013 10:51:22 +0800 [thread overview]
Message-ID: <20130829025122.GA451@hacker.(null)> (raw)
In-Reply-To: <CAE9FiQVPmjxCzOCPQWz4=6JwzB-Vn5YMtOEd-G97SvEgoY3RQg@mail.gmail.com>
Hi Yinghai,
On Wed, Aug 28, 2013 at 07:42:29PM -0700, Yinghai Lu wrote:
>On Wed, Aug 28, 2013 at 7:34 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>> On Wed, Aug 28, 2013 at 7:18 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>>> please change to function pointer to
>>> void (*alloc_func)(void *data,
>>> unsigned long pnum_begin,
>>> unsigned long pnum_end,
>>> unsigned long map_count, int nodeid)
>>>
>>> pnum_begin, pnum_end, map_coun, nodeid, should not be in the struct.
>>
>> looks like that is what is your first version did.
>>
>> I updated it a little bit. please check it.
>>
>
>removed more lines.
Thanks for your great work!
The fixed patch looks good to me. If this is the last fix and I can
ignore http://marc.info/?l=linux-mm&m=137774271220239&w=2?
Regards,
Wanpeng Li
>
>Yinghai
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-29 2:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 6:54 [PATCH v2 1/4] mm/pgtable: Fix continue to preallocate pmds even if failure occurrence Wanpeng Li
2013-08-20 6:54 ` [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap Wanpeng Li
2013-08-20 23:07 ` Andrew Morton
2013-08-21 0:02 ` Yinghai Lu
2013-08-21 3:11 ` Wanpeng Li
2013-08-21 3:11 ` Wanpeng Li
[not found] ` <52142ffe.84c0440a.57e5.02acSMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-21 4:28 ` Yinghai Lu
2013-08-21 7:29 ` Wanpeng Li
2013-08-21 7:29 ` Wanpeng Li
[not found] ` <52146c58.a3e2440a.0f5a.ffffed8dSMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-22 5:19 ` Yinghai Lu
2013-08-22 12:08 ` Wanpeng Li
2013-08-22 12:08 ` Wanpeng Li
2013-08-22 12:14 ` Wanpeng Li
2013-08-22 12:14 ` Wanpeng Li
[not found] ` <521600cc.22ab440a.2703.53f1SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-29 2:18 ` Yinghai Lu
2013-08-29 2:34 ` Yinghai Lu
2013-08-29 2:42 ` Yinghai Lu
2013-08-29 2:51 ` Wanpeng Li
2013-08-29 2:51 ` Wanpeng Li [this message]
[not found] ` <521eb73e.e3bf420a.2ad0.09c2SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-29 4:10 ` Yinghai Lu
2013-08-29 5:32 ` Wanpeng Li
2013-08-29 5:32 ` Wanpeng Li
2013-08-20 6:54 ` [PATCH v2 3/4] mm/writeback: make writeback_inodes_wb static Wanpeng Li
2013-08-20 16:01 ` Seth Jennings
2013-08-20 6:54 ` [PATCH v2 4/4] mm/vmalloc: use wrapper function get_vm_area_size to caculate size of vm area Wanpeng Li
2013-08-20 16:03 ` Seth Jennings
2013-08-20 16:00 ` [PATCH v2 1/4] mm/pgtable: Fix continue to preallocate pmds even if failure occurrence Seth Jennings
2013-08-20 23:04 ` Andrew Morton
2013-08-20 23:39 ` Wanpeng Li
2013-08-20 23:39 ` Wanpeng Li
[not found] ` <5213fe45.660c420a.4066.ffffd8c7SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-21 0:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130829025122.GA451@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jkosina@suse.cz \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox