From: Russ Anderson <rja@sgi.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] [BUGFIX] drivers/base: fix show_mem_removable section count
Date: Fri, 23 Aug 2013 11:08:02 -0500 [thread overview]
Message-ID: <20130823160802.GA10988@sgi.com> (raw)
In-Reply-To: <52170DDE.4010103@jp.fujitsu.com>
On Fri, Aug 23, 2013 at 04:23:10PM +0900, Yasuaki Ishimatsu wrote:
>
> I don't think it works well.
> mem->section_count means how many present section is in the memory_block.
> If 0, 1, 3 and 4 sections are present in the memory_block, mem->section_count
> is 4. In this case, is_mem_sectionremovable is called for section 2. But the
> section is not present. So if the memory_block has hole, same problem will occur.
>
> How about keep sections_per_block loop and add following check:
>
> if (!present_section_nr(mem->start_section_nr + i))
> continue;
Yes, I will make that change and resubmit the patch.
Thanks.
> Thanks,
> Yasuaki Ishimatsu
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-08-23 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 2:38 Russ Anderson
2013-08-23 4:10 ` Greg Kroah-Hartman
2013-08-23 4:17 ` Russ Anderson
2013-08-23 4:46 ` Greg Kroah-Hartman
2013-08-23 7:23 ` Yasuaki Ishimatsu
2013-08-23 16:08 ` Russ Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823160802.GA10988@sgi.com \
--to=rja@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael.j.wysocki@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox