From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id 284D46B0036 for ; Thu, 22 Aug 2013 07:11:52 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <20130821142817.8EB4BE0090@blue.fi.intel.com> Subject: RE: [patch] mm, thp: count thp_fault_fallback anytime thp fault fails Content-Transfer-Encoding: 7bit Message-Id: <20130822111148.B931AE0090@blue.fi.intel.com> Date: Thu, 22 Aug 2013 14:11:48 +0300 (EEST) Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org David Rientjes wrote: > On Wed, 21 Aug 2013, Kirill A. Shutemov wrote: > > > David Rientjes wrote: > > > Currently, thp_fault_fallback in vmstat only gets incremented if a > > > hugepage allocation fails. If current's memcg hits its limit or the page > > > fault handler returns an error, it is incorrectly accounted as a > > > successful thp_fault_alloc. > > > > > > Count thp_fault_fallback anytime the page fault handler falls back to > > > using regular pages and only count thp_fault_alloc when a hugepage has > > > actually been faulted. > > > > > > Signed-off-by: David Rientjes > > > > It's probably a good idea, but please make the behaviour consistent in > > do_huge_pmd_wp_page() and collapse path, otherwise it doesn't make sense. > > > > The collapse path has no fallback, the allocation either succeeds or it > fails. THP_COLLAPSE_ALLOC should be counted after successful memcg charge or even only after successful collapse. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org