From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx121.postini.com [74.125.245.121]) by kanga.kvack.org (Postfix) with SMTP id 53F3E6B0032 for ; Thu, 15 Aug 2013 11:39:32 -0400 (EDT) Date: Thu, 15 Aug 2013 16:39:27 +0100 From: Mel Gorman Subject: [PATCH] mm: compaction: Do not compact pgdat for order-0 Message-ID: <20130815153927.GZ2296@suse.de> References: <20130815104727.GT2296@suse.de> <20130815134139.GC8437@gmail.com> <20130815135627.GX2296@suse.de> <20130815141004.GD8437@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130815141004.GD8437@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Hillf Danton , Minchan Kim , LKML , Linux-MM If kswapd was reclaiming for a high order and resets it to 0 due to fragmentation it will still call compact_pgdat. For the most part, this will fail a compaction_suitable() test and not compact but it is unnecessarily sloppy. It could be fixed in the caller but fix it in the API instead. [dhillf@gmail.com: Pointed out that it was a potential problem] Signed-off-by: Mel Gorman --- mm/compaction.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/compaction.c b/mm/compaction.c index 05ccb4c..c437893 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1131,6 +1131,9 @@ void compact_pgdat(pg_data_t *pgdat, int order) .sync = false, }; + if (!order) + return; + __compact_pgdat(pgdat, &cc); } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org