linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
	Luigi Semenzato <semenzato@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>, Nitin Gupta <ngupta@vflare.org>,
	Konrad Rzeszutek Wilk <konrad@darnok.org>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v6 0/5] zram/zsmalloc promotion
Date: Thu, 15 Aug 2013 10:03:25 -0500	[thread overview]
Message-ID: <20130815150325.GA4729@medulla.variantweb.net> (raw)
In-Reply-To: <CAA_GA1da3jkOO9Y3+L6_DMmiH8wsbJJ-xcUxUK_Gh2SYPPbjoA@mail.gmail.com>

On Thu, Aug 15, 2013 at 08:18:46AM +0800, Bob Liu wrote:
> On Thu, Aug 15, 2013 at 12:17 AM, Minchan Kim <minchan@kernel.org> wrote:
> > Hi Luigi,
> >
> > On Wed, Aug 14, 2013 at 08:53:31AM -0700, Luigi Semenzato wrote:
> >> During earlier discussions of zswap there was a plan to make it work
> >> with zsmalloc as an option instead of zbud. Does zbud work for
> >
> > AFAIR, it was not an optoin but zsmalloc was must but there were
> > several objections because zswap's notable feature is to dump
> > compressed object to real swap storage. For that, zswap needs to
> > store bounded objects in a zpage so that dumping could be bounded, too.
> > Otherwise, it could encounter OOM easily.
> >
> 
> AFAIR, the next step of zswap should be have a modular allocation layer so that
> users can choose zsmalloc or zbud to use.
> 
> Seth?

Yes, that should be doable without too much effort, at least if you
disregard writeback.  I believe I wrote the code so that you can make
the registration of the eviction handler for the allocator NULL, in
which case, zswap can just fail the store and fall back to swap. That
reintroduces the inverse LRU issue when the pool is full, but in the
meantime you potentially get much better effective compression.  Then
tackle zsmalloc writeback separately.

Seth

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-08-15 15:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  5:55 Minchan Kim
2013-08-14  5:55 ` [PATCH v6 1/5] zsmalloc: add Kconfig for enabling page table method Minchan Kim
2013-08-14  5:55 ` [PATCH v6 2/5] zsmalloc: add more comment Minchan Kim
2013-08-14  5:55 ` [PATCH v6 3/5] zsmalloc: move it under zram Minchan Kim
2013-08-16 22:00   ` Seth Jennings
2013-08-20  4:21     ` Minchan Kim
2013-08-14  5:55 ` [PATCH v6 4/5] mm: export unmap_kernel_range Minchan Kim
2013-08-14  5:55 ` [PATCH v6 5/5] zram: promote zram from staging Minchan Kim
2013-08-14 15:53 ` [PATCH v6 0/5] zram/zsmalloc promotion Luigi Semenzato
2013-08-14 16:17   ` Minchan Kim
2013-08-15  0:18     ` Bob Liu
2013-08-15 15:03       ` Seth Jennings [this message]
2013-08-16  2:02     ` Wanpeng Li
2013-08-16  2:02     ` Wanpeng Li
     [not found]     ` <520d883a.a2f6420a.6f36.0d66SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-16  4:35       ` Minchan Kim
2013-08-16  7:02         ` Alex Elsayed
2013-08-14 17:40 ` Mel Gorman
2013-08-14 18:15   ` Luigi Semenzato
2013-08-14 18:58   ` Minchan Kim
2013-08-15 17:12     ` Mel Gorman
2013-08-16  1:52       ` Bob Liu
2013-08-16  1:53       ` Bob Liu
2013-08-16  4:26       ` Minchan Kim
2013-08-16  4:55         ` Bob Liu
2013-08-16  8:33         ` Mel Gorman
2013-08-16  9:12           ` Mel Gorman
2013-08-16  9:18             ` Bob Liu
2013-08-16 12:49               ` Greg Kroah-Hartman
2013-08-16  9:12           ` Bob Liu
2013-08-19  3:18           ` Minchan Kim
2013-08-19  3:57             ` Bob Liu
2013-08-19  4:37               ` Minchan Kim
2013-08-19  5:29                 ` Luigi Semenzato
2013-08-19  6:07                   ` Bob Liu
2013-08-19  6:11                   ` Minchan Kim
  -- strict thread matches above, loose matches on Subject: below --
2013-08-14  5:51 Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815150325.GA4729@medulla.variantweb.net \
    --to=sjenning@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad@darnok.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lliubbo@gmail.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=semenzato@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox