From: Andrew Morton <akpm@linux-foundation.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
dave@sr71.net, isimatu.yasuaki@jp.fujitsu.com,
tangchen@cn.fujitsu.com, vasilis.liaskovitis@profitbricks.com
Subject: Re: [PATCH v2] mm/hotplug: Verify hotplug memory range
Date: Wed, 14 Aug 2013 16:45:08 -0700 [thread overview]
Message-ID: <20130814164508.e62614c436df5eabfd504c8c@linux-foundation.org> (raw)
In-Reply-To: <1376523242.10300.403.camel@misato.fc.hp.com>
On Wed, 14 Aug 2013 17:34:02 -0600 Toshi Kani <toshi.kani@hp.com> wrote:
> > Printing a u64 is problematic. Here you assume that u64 is implemented
> > as unsigned long long. But it can be implemented as unsigned long, by
> > architectures which use include/asm-generic/int-l64.h. Such an
> > architecture will generate a compile warning here, but I can't
> > immediately find a Kconfig combination which will make that happen.
>
> Oh, I see. Should I add the casting below and resend it to you?
>
> (unsigned long long)start, (unsigned long long)size);
I was going to leave it as-is and see if anyone else can find a way of
triggering the warning. But other sites in mm/memory_hotplug.c have
the casts so I went ahead and fixed it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-14 23:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 19:17 Toshi Kani
2013-08-11 23:37 ` Wanpeng Li
2013-08-11 23:37 ` Wanpeng Li
2013-08-12 14:49 ` Toshi Kani
2013-08-14 22:09 ` Andrew Morton
2013-08-14 23:34 ` Toshi Kani
2013-08-14 23:45 ` Andrew Morton [this message]
2013-08-14 23:45 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814164508.e62614c436df5eabfd504c8c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tangchen@cn.fujitsu.com \
--cc=toshi.kani@hp.com \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox