From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx137.postini.com [74.125.245.137]) by kanga.kvack.org (Postfix) with SMTP id E1DBE6B0032 for ; Wed, 14 Aug 2013 19:40:54 -0400 (EDT) Date: Wed, 14 Aug 2013 16:40:52 -0700 From: Andrew Morton Subject: Re: [PATCH v5 0/9] extend hugepage migration Message-Id: <20130814164052.2ccdd5bdf7ab56deeba88e68@linux-foundation.org> In-Reply-To: <1376025702-14818-1-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1376025702-14818-1-git-send-email-n-horiguchi@ah.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Hillf Danton , Michal Hocko , Rik van Riel , "Aneesh Kumar K.V" , Wanpeng Li , linux-kernel@vger.kernel.org, Naoya Horiguchi On Fri, 9 Aug 2013 01:21:33 -0400 Naoya Horiguchi wrote: > Here is the 5th version of hugepage migration patchset. > Changes in this version are as follows: > - removed putback_active_hugepages() as a cleanup (1/9) > - added code to check movability of a given hugepage (8/9) > - set GFP MOVABLE flag depending on the movability of hugepage (9/9). > > I feel that 8/9 and 9/9 contain some new things, so need reviews on them. > > TODOs: (likely to be done after this work) > - split page table lock for pmd/pud based hugepage (maybe applicable to thp) > - improve alloc_migrate_target (especially in node choice) > - using page walker in check_range This is a pretty large and complex patchset. I skimmed the patches (and have one trivial comment) then queued them up for a bit of testing. I've asked Mel if he can find time to review the changes (please). btw, it would be helpful if this [patch 0/n] had a decent overview of the patch series - what are the objectives, how were they achieved, what value they have to our users, testing results, etc. mm-prepare-to-remove-proc-sys-vm-hugepages_treat_as_movable.patch had a conflict with http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-move-up-the-code-which-check-availability-of-free-huge-page.patch which I resolved in the obvious manner. Please check that from a runtime perspective. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org