From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id E2EAF6B0032 for ; Tue, 13 Aug 2013 17:16:23 -0400 (EDT) Date: Tue, 13 Aug 2013 14:16:21 -0700 From: Andrew Morton Subject: Re: [PATCH v4 2/2] mm: make lru_add_drain_all() selective Message-Id: <20130813141621.3f1c3415901d4236942ee736@linux-foundation.org> In-Reply-To: <20130813210719.GB28996@mtj.dyndns.org> References: <5202CEAA.9040204@linux.vnet.ibm.com> <201308072335.r77NZZwl022494@farm-0012.internal.tilera.com> <20130812140520.c6a2255d2176a690fadf9ba7@linux-foundation.org> <52099187.80301@tilera.com> <20130813123512.3d6865d8bf4689c05d44738c@linux-foundation.org> <20130813201958.GA28996@mtj.dyndns.org> <20130813133135.3b580af557d1457e4ee8331a@linux-foundation.org> <20130813210719.GB28996@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Chris Metcalf , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Gleixner , Frederic Weisbecker , Cody P Schafer On Tue, 13 Aug 2013 17:07:19 -0400 Tejun Heo wrote: > > I don't recall seeing such abuse. It's a very common and powerful > > tool, and not implementing it because some dummy may abuse it weakens > > the API for all non-dummies. That allocation is simply unneeded. > > More powerful and flexible doesn't always equal better and I think > being simple and less prone to abuses are important characteristics > that APIs should have. I've yet to see any evidence that callback APIs have been abused and I've yet to see any reasoning which makes me believe that this one will be abused. > It feels a bit silly to me to push the API > that way when doing so doesn't even solve the allocation problem. It removes the need to perform a cpumask allocation in lru_add_drain_all(). > It doesn't really buy us much while making the interface more complex. It's a superior interface. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org