* [PATCH] mm/Kconfig: add MMU dependency for MIGRATION.
@ 2013-08-01 2:39 Chen Gang
2013-08-05 7:32 ` Michal Hocko
0 siblings, 1 reply; 8+ messages in thread
From: Chen Gang @ 2013-08-01 2:39 UTC (permalink / raw)
To: sfr, rientjes, riel, isimatu.yasuaki; +Cc: Andrew Morton, linux-mm
MIGRATION need depend on MMU, or allmodconfig for sh architecture which
without MMU will be fail for compiling.
The related error:
CC mm/migrate.o
mm/migrate.c: In function 'remove_migration_pte':
mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration]
if (pmd_trans_huge(*pmd))
^
mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration]
if (!is_swap_pte(pte))
^
...
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
mm/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index 256bfd0..e847f19 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -245,7 +245,7 @@ config COMPACTION
config MIGRATION
bool "Page migration"
def_bool y
- depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA
+ depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU
help
Allows the migration of the physical location of pages of processes
while the virtual addresses are not changed. This is useful in
@@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY
config CMA
bool "Contiguous Memory Allocator"
- depends on HAVE_MEMBLOCK
+ depends on HAVE_MEMBLOCK && MMU
select MIGRATION
select MEMORY_ISOLATION
help
--
1.7.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-01 2:39 [PATCH] mm/Kconfig: add MMU dependency for MIGRATION Chen Gang @ 2013-08-05 7:32 ` Michal Hocko 2013-08-05 8:46 ` Chen Gang F T 0 siblings, 1 reply; 8+ messages in thread From: Michal Hocko @ 2013-08-05 7:32 UTC (permalink / raw) To: Chen Gang; +Cc: sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm On Thu 01-08-13 10:39:57, Chen Gang wrote: > MIGRATION need depend on MMU, or allmodconfig for sh architecture which > without MMU will be fail for compiling. > > The related error: > > CC mm/migrate.o > mm/migrate.c: In function 'remove_migration_pte': > mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] > if (pmd_trans_huge(*pmd)) > ^ > mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] > if (!is_swap_pte(pte)) > ^ > ... > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > mm/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 256bfd0..e847f19 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -245,7 +245,7 @@ config COMPACTION > config MIGRATION > bool "Page migration" > def_bool y > - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA > + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU > help > Allows the migration of the physical location of pages of processes > while the virtual addresses are not changed. This is useful in > @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY > > config CMA > bool "Contiguous Memory Allocator" > - depends on HAVE_MEMBLOCK > + depends on HAVE_MEMBLOCK && MMU Why CMA has to depend on MMU as well? The MIGRATION part should be sufficient. > select MIGRATION > select MEMORY_ISOLATION > help -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-05 7:32 ` Michal Hocko @ 2013-08-05 8:46 ` Chen Gang F T 2013-08-05 9:03 ` Michal Hocko 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang F T @ 2013-08-05 8:46 UTC (permalink / raw) To: Michal Hocko Cc: Chen Gang, sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm On 08/05/2013 03:32 PM, Michal Hocko wrote: > On Thu 01-08-13 10:39:57, Chen Gang wrote: >> MIGRATION need depend on MMU, or allmodconfig for sh architecture which >> without MMU will be fail for compiling. >> >> The related error: >> >> CC mm/migrate.o >> mm/migrate.c: In function 'remove_migration_pte': >> mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] >> if (pmd_trans_huge(*pmd)) >> ^ >> mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] >> if (!is_swap_pte(pte)) >> ^ >> ... >> >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> --- >> mm/Kconfig | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 256bfd0..e847f19 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -245,7 +245,7 @@ config COMPACTION >> config MIGRATION >> bool "Page migration" >> def_bool y >> - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA >> + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU >> help >> Allows the migration of the physical location of pages of processes >> while the virtual addresses are not changed. This is useful in >> @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY >> >> config CMA >> bool "Contiguous Memory Allocator" >> - depends on HAVE_MEMBLOCK >> + depends on HAVE_MEMBLOCK && MMU > > Why CMA has to depend on MMU as well? The MIGRATION part should be > sufficient. > MIGRATION need depend on MMU, when NOMMU, if select CMA, it will select MIGRATION by force. e.g. for allmodconfig with sh architecture, if we only let MIGRATION depend on MMU, not let CMA depend on MMU, it will report the warning below: scripts/kconfig/conf --allmodconfig Kconfig warning: (COMPACTION && CMA) selects MIGRATION which has unmet direct dependencies ((NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU) And for the final config file, MIGRATION is still enabled, although MMU is not defined. >> select MIGRATION >> select MEMORY_ISOLATION >> help > Thanks. -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-05 8:46 ` Chen Gang F T @ 2013-08-05 9:03 ` Michal Hocko 2013-08-05 9:05 ` Michal Hocko 0 siblings, 1 reply; 8+ messages in thread From: Michal Hocko @ 2013-08-05 9:03 UTC (permalink / raw) To: Chen Gang F T Cc: Chen Gang, sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm On Mon 05-08-13 16:46:14, Chen Gang F T wrote: > On 08/05/2013 03:32 PM, Michal Hocko wrote: > > On Thu 01-08-13 10:39:57, Chen Gang wrote: > >> MIGRATION need depend on MMU, or allmodconfig for sh architecture which > >> without MMU will be fail for compiling. > >> > >> The related error: > >> > >> CC mm/migrate.o > >> mm/migrate.c: In function 'remove_migration_pte': > >> mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] > >> if (pmd_trans_huge(*pmd)) > >> ^ > >> mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] > >> if (!is_swap_pte(pte)) > >> ^ > >> ... > >> > >> > >> Signed-off-by: Chen Gang <gang.chen@asianux.com> > >> --- > >> mm/Kconfig | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/mm/Kconfig b/mm/Kconfig > >> index 256bfd0..e847f19 100644 > >> --- a/mm/Kconfig > >> +++ b/mm/Kconfig > >> @@ -245,7 +245,7 @@ config COMPACTION > >> config MIGRATION > >> bool "Page migration" > >> def_bool y > >> - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA > >> + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU > >> help > >> Allows the migration of the physical location of pages of processes > >> while the virtual addresses are not changed. This is useful in > >> @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY > >> > >> config CMA > >> bool "Contiguous Memory Allocator" > >> - depends on HAVE_MEMBLOCK > >> + depends on HAVE_MEMBLOCK && MMU > > > > Why CMA has to depend on MMU as well? The MIGRATION part should be > > sufficient. > > > > MIGRATION need depend on MMU, when NOMMU, if select CMA, it will select > MIGRATION by force. Ohh, I wasn't aware of this Kcofing limitation. You are right then and CMA needs a dependency as well. > e.g. for allmodconfig with sh architecture, if we only let MIGRATION > depend on MMU, not let CMA depend on MMU, it will report the warning > below: > > scripts/kconfig/conf --allmodconfig Kconfig > warning: (COMPACTION && CMA) selects MIGRATION which has unmet direct dependencies ((NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU) > > And for the final config file, MIGRATION is still enabled, although MMU > is not defined. > > > >> select MIGRATION > >> select MEMORY_ISOLATION > >> help > > > > Thanks. > -- > Chen Gang > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-05 9:03 ` Michal Hocko @ 2013-08-05 9:05 ` Michal Hocko 2013-08-05 9:13 ` Chen Gang F T 0 siblings, 1 reply; 8+ messages in thread From: Michal Hocko @ 2013-08-05 9:05 UTC (permalink / raw) To: Chen Gang F T Cc: Chen Gang, sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm On Mon 05-08-13 11:03:01, Michal Hocko wrote: > On Mon 05-08-13 16:46:14, Chen Gang F T wrote: > > On 08/05/2013 03:32 PM, Michal Hocko wrote: > > > On Thu 01-08-13 10:39:57, Chen Gang wrote: > > >> MIGRATION need depend on MMU, or allmodconfig for sh architecture which > > >> without MMU will be fail for compiling. > > >> > > >> The related error: > > >> > > >> CC mm/migrate.o > > >> mm/migrate.c: In function 'remove_migration_pte': > > >> mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] > > >> if (pmd_trans_huge(*pmd)) > > >> ^ > > >> mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] > > >> if (!is_swap_pte(pte)) > > >> ^ > > >> ... > > >> > > >> > > >> Signed-off-by: Chen Gang <gang.chen@asianux.com> > > >> --- > > >> mm/Kconfig | 4 ++-- > > >> 1 files changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/mm/Kconfig b/mm/Kconfig > > >> index 256bfd0..e847f19 100644 > > >> --- a/mm/Kconfig > > >> +++ b/mm/Kconfig > > >> @@ -245,7 +245,7 @@ config COMPACTION > > >> config MIGRATION > > >> bool "Page migration" > > >> def_bool y > > >> - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA > > >> + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU > > >> help > > >> Allows the migration of the physical location of pages of processes > > >> while the virtual addresses are not changed. This is useful in > > >> @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY > > >> > > >> config CMA > > >> bool "Contiguous Memory Allocator" > > >> - depends on HAVE_MEMBLOCK > > >> + depends on HAVE_MEMBLOCK && MMU > > > > > > Why CMA has to depend on MMU as well? The MIGRATION part should be > > > sufficient. > > > > > > > MIGRATION need depend on MMU, when NOMMU, if select CMA, it will select > > MIGRATION by force. > > Ohh, I wasn't aware of this Kcofing limitation. You are right then and > CMA needs a dependency as well. Could you mention this in the changelog please. Feel free to add Reviewed-by: Michal Hocko <mhocko@suse.cz> > > e.g. for allmodconfig with sh architecture, if we only let MIGRATION > > depend on MMU, not let CMA depend on MMU, it will report the warning > > below: > > > > scripts/kconfig/conf --allmodconfig Kconfig > > warning: (COMPACTION && CMA) selects MIGRATION which has unmet direct dependencies ((NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU) > > > > And for the final config file, MIGRATION is still enabled, although MMU > > is not defined. > > > > > > >> select MIGRATION > > >> select MEMORY_ISOLATION > > >> help > > > > > > > Thanks. > > -- > > Chen Gang > > > > -- > > To unsubscribe, send a message with 'unsubscribe linux-mm' in > > the body to majordomo@kvack.org. For more info on Linux MM, > > see: http://www.linux-mm.org/ . > > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > > -- > Michal Hocko > SUSE Labs > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-05 9:05 ` Michal Hocko @ 2013-08-05 9:13 ` Chen Gang F T 2013-08-05 9:20 ` [PATCH v2] " Chen Gang 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang F T @ 2013-08-05 9:13 UTC (permalink / raw) To: Michal Hocko Cc: Chen Gang, sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm On 08/05/2013 05:05 PM, Michal Hocko wrote: > On Mon 05-08-13 11:03:01, Michal Hocko wrote: >> > On Mon 05-08-13 16:46:14, Chen Gang F T wrote: >>> > > On 08/05/2013 03:32 PM, Michal Hocko wrote: >>>> > > > On Thu 01-08-13 10:39:57, Chen Gang wrote: >>>>> > > >> MIGRATION need depend on MMU, or allmodconfig for sh architecture which >>>>> > > >> without MMU will be fail for compiling. >>>>> > > >> >>>>> > > >> The related error: >>>>> > > >> >>>>> > > >> CC mm/migrate.o >>>>> > > >> mm/migrate.c: In function 'remove_migration_pte': >>>>> > > >> mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] >>>>> > > >> if (pmd_trans_huge(*pmd)) >>>>> > > >> ^ >>>>> > > >> mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] >>>>> > > >> if (!is_swap_pte(pte)) >>>>> > > >> ^ >>>>> > > >> ... >>>>> > > >> >>>>> > > >> >>>>> > > >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >>>>> > > >> --- >>>>> > > >> mm/Kconfig | 4 ++-- >>>>> > > >> 1 files changed, 2 insertions(+), 2 deletions(-) >>>>> > > >> >>>>> > > >> diff --git a/mm/Kconfig b/mm/Kconfig >>>>> > > >> index 256bfd0..e847f19 100644 >>>>> > > >> --- a/mm/Kconfig >>>>> > > >> +++ b/mm/Kconfig >>>>> > > >> @@ -245,7 +245,7 @@ config COMPACTION >>>>> > > >> config MIGRATION >>>>> > > >> bool "Page migration" >>>>> > > >> def_bool y >>>>> > > >> - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA >>>>> > > >> + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU >>>>> > > >> help >>>>> > > >> Allows the migration of the physical location of pages of processes >>>>> > > >> while the virtual addresses are not changed. This is useful in >>>>> > > >> @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY >>>>> > > >> >>>>> > > >> config CMA >>>>> > > >> bool "Contiguous Memory Allocator" >>>>> > > >> - depends on HAVE_MEMBLOCK >>>>> > > >> + depends on HAVE_MEMBLOCK && MMU >>>> > > > >>>> > > > Why CMA has to depend on MMU as well? The MIGRATION part should be >>>> > > > sufficient. >>>> > > > >>> > > >>> > > MIGRATION need depend on MMU, when NOMMU, if select CMA, it will select >>> > > MIGRATION by force. >> > >> > Ohh, I wasn't aware of this Kcofing limitation. You are right then and >> > CMA needs a dependency as well. OK, thanks. Every member may make mistakes (e.g. me), although we should try to avoid to make mistakes (at least, every member don't want to make mistakes by themselves ). > Could you mention this in the changelog please. > Feel free to add > Reviewed-by: Michal Hocko <mhocko@suse.cz> > OK, thanks, I will do. >>> > > e.g. for allmodconfig with sh architecture, if we only let MIGRATION >>> > > depend on MMU, not let CMA depend on MMU, it will report the warning >>> > > below: >>> > > >>> > > scripts/kconfig/conf --allmodconfig Kconfig >>> > > warning: (COMPACTION && CMA) selects MIGRATION which has unmet direct dependencies ((NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU) >>> > > >>> > > And for the final config file, MIGRATION is still enabled, although MMU >>> > > is not defined. >>> > > >>> > > >>>>> > > >> select MIGRATION >>>>> > > >> select MEMORY_ISOLATION >>>>> > > >> help >>>> > > > >>> > > >>> > > Thanks. >>> > > -- >>> > > Chen Gang >>> > > >>> > > -- >>> > > To unsubscribe, send a message with 'unsubscribe linux-mm' in >>> > > the body to majordomo@kvack.org. For more info on Linux MM, >>> > > see: http://www.linux-mm.org/ . >>> > > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >> > >> > -- >> > Michal Hocko >> > SUSE Labs >> > >> > -- >> > To unsubscribe, send a message with 'unsubscribe linux-mm' in >> > the body to majordomo@kvack.org. For more info on Linux MM, >> > see: http://www.linux-mm.org/ . >> > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- Michal Hocko SUSE Labs > -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-05 9:13 ` Chen Gang F T @ 2013-08-05 9:20 ` Chen Gang 2013-08-06 9:10 ` Chen Gang 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang @ 2013-08-05 9:20 UTC (permalink / raw) To: Michal Hocko Cc: sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm MIGRATION need depend on MMU, or allmodconfig for sh architecture which without MMU will be fail for compiling. The related error: CC mm/migrate.o mm/migrate.c: In function 'remove_migration_pte': mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] if (pmd_trans_huge(*pmd)) ^ mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] if (!is_swap_pte(pte)) ^ ... Also need let CMA depend on MMU, or when NOMMU, if select CMA, it will select MIGRATION by force. Signed-off-by: Chen Gang <gang.chen@asianux.com> Reviewed-by: Michal Hocko <mhocko@suse.cz> --- mm/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index 256bfd0..e847f19 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -245,7 +245,7 @@ config COMPACTION config MIGRATION bool "Page migration" def_bool y - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU help Allows the migration of the physical location of pages of processes while the virtual addresses are not changed. This is useful in @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY config CMA bool "Contiguous Memory Allocator" - depends on HAVE_MEMBLOCK + depends on HAVE_MEMBLOCK && MMU select MIGRATION select MEMORY_ISOLATION help -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] mm/Kconfig: add MMU dependency for MIGRATION. 2013-08-05 9:20 ` [PATCH v2] " Chen Gang @ 2013-08-06 9:10 ` Chen Gang 0 siblings, 0 replies; 8+ messages in thread From: Chen Gang @ 2013-08-06 9:10 UTC (permalink / raw) To: Michal Hocko Cc: sfr, rientjes, riel, isimatu.yasuaki, Andrew Morton, linux-mm On 08/05/2013 05:20 PM, Chen Gang wrote: > > > Sorry for my careless sending: reserving so many waste empty lines. > MIGRATION need depend on MMU, or allmodconfig for sh architecture which > without MMU will be fail for compiling. > > The related error: > > CC mm/migrate.o > mm/migrate.c: In function 'remove_migration_pte': > mm/migrate.c:134:3: error: implicit declaration of function 'pmd_trans_huge' [-Werror=implicit-function-declaration] > if (pmd_trans_huge(*pmd)) > ^ > mm/migrate.c:149:2: error: implicit declaration of function 'is_swap_pte' [-Werror=implicit-function-declaration] > if (!is_swap_pte(pte)) > ^ > ... > > Also need let CMA depend on MMU, or when NOMMU, if select CMA, it will > select MIGRATION by force. > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > Reviewed-by: Michal Hocko <mhocko@suse.cz> > --- > mm/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 256bfd0..e847f19 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -245,7 +245,7 @@ config COMPACTION > config MIGRATION > bool "Page migration" > def_bool y > - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA > + depends on (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU > help > Allows the migration of the physical location of pages of processes > while the virtual addresses are not changed. This is useful in > @@ -522,7 +522,7 @@ config MEM_SOFT_DIRTY > > config CMA > bool "Contiguous Memory Allocator" > - depends on HAVE_MEMBLOCK > + depends on HAVE_MEMBLOCK && MMU > select MIGRATION > select MEMORY_ISOLATION > help > -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-08-06 9:11 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-08-01 2:39 [PATCH] mm/Kconfig: add MMU dependency for MIGRATION Chen Gang 2013-08-05 7:32 ` Michal Hocko 2013-08-05 8:46 ` Chen Gang F T 2013-08-05 9:03 ` Michal Hocko 2013-08-05 9:05 ` Michal Hocko 2013-08-05 9:13 ` Chen Gang F T 2013-08-05 9:20 ` [PATCH v2] " Chen Gang 2013-08-06 9:10 ` Chen Gang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox