linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, liuj97@gmail.com,
	kosaki.motohiro@gmail.com
Subject: Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
Date: Sun, 4 Aug 2013 15:49:56 +0800	[thread overview]
Message-ID: <20130804074956.GA10354@hacker.(null)> (raw)
In-Reply-To: <1375260602-2462-1-git-send-email-jy0922.shim@samsung.com>

On Wed, Jul 31, 2013 at 05:50:02PM +0900, Joonyoung Shim wrote:
>This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>
>Fixed to adjust totalhigh_pages when hot-removing memory by commit
>3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>duplicated decreasing of totalhigh_pages.
>

Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

>Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>---
>The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
>is it right?
>
> mm/page_alloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>index b100255..2b28216 100644
>--- a/mm/page_alloc.c
>+++ b/mm/page_alloc.c
>@@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> 		list_del(&page->lru);
> 		rmv_page_order(page);
> 		zone->free_area[order].nr_free--;
>-#ifdef CONFIG_HIGHMEM
>-		if (PageHighMem(page))
>-			totalhigh_pages -= 1 << order;
>-#endif
> 		for (i = 0; i < (1 << order); i++)
> 			SetPageReserved((page+i));
> 		pfn += (1 << order);
>-- 
>1.8.1.2
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2013-08-04  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31  8:50 Joonyoung Shim
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
2013-07-31 11:48   ` Bartlomiej Zolnierkiewicz
2013-08-09  0:58     ` Joonyoung Shim
2013-08-04  7:49 ` Wanpeng Li
2013-08-04  7:49 ` Wanpeng Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20130804074956.GA10354@hacker.(null)' \
    --to=liwanp@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=jy0922.shim@samsung.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuj97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox