linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Sha Zhengju <handai.szj@gmail.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
	kamezawa.hiroyu@jp.fujitsu.com, glommer@gmail.com,
	gthelen@google.com, fengguang.wu@intel.com,
	akpm@linux-foundation.org, Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH V5 0/8] Add memcg dirty/writeback page accounting
Date: Thu, 1 Aug 2013 16:43:26 +0200	[thread overview]
Message-ID: <20130801144326.GI5198@dhcp22.suse.cz> (raw)
In-Reply-To: <1375357402-9811-1-git-send-email-handai.szj@taobao.com>

On Thu 01-08-13 19:43:22, Sha Zhengju wrote:
[...]
> Some perforcemance numbers got by Mel's pft test (On a 4g memory and 4-core
> i5 CPU machine):

I am little bit confused what is this testcase actually testing... AFAIU
it produces a lot of page faults but they are all anonymous and very
short lived. So neither dirty nor writeback accounting is done.

I would have expected a testcase which generates a lot of IO.

Also as a general note. It would be better to mention the number of runs
and standard deviation so that we have an idea about variability of the
load.

> vanilla  : memcg enabled, patch not applied
> patched  : all patches are patched
> 
> * Duration numbers:
>              vanilla     patched
> User          385.38      379.47
> System         65.12       66.46
> Elapsed       457.46      452.21
> 
> * Summary numbers:
> vanilla:
> Clients User        System      Elapsed     Faults/cpu  Faults/sec  
> 1       0.03        0.18        0.21        931682.645  910993.850  
> 2       0.03        0.22        0.13        760431.152  1472985.863 
> 3       0.03        0.29        0.12        600495.043  1620311.084 
> 4       0.04        0.37        0.12        475380.531  1688013.267
> 
> patched:
> Clients User        System      Elapsed     Faults/cpu  Faults/sec  
> 1       0.02        0.19        0.22        915362.875  898763.732  
> 2       0.03        0.23        0.13        757518.387  1464893.996 
> 3       0.03        0.30        0.12        592113.126  1611873.469 
> 4       0.04        0.38        0.12        472203.393  1680013.271
> 
> We can see the performance gap is minor.
[...]
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-08-01 14:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 11:43 Sha Zhengju
2013-08-01 11:44 ` [PATCH 1/8] memcg: remove MEMCG_NR_FILE_MAPPED Sha Zhengju
2013-08-01 11:51 ` [PATCH V5 2/8] fs/ceph: vfs __set_page_dirty_nobuffers interface instead of doing it inside filesystem Sha Zhengju
2013-08-01 15:19   ` Yan, Zheng
2013-08-01 18:27     ` Sage Weil
2013-08-02 10:04       ` Sha Zhengju
2013-08-02 20:30         ` Sage Weil
2013-08-03  8:58           ` Sha Zhengju
2013-08-02  9:04     ` Sha Zhengju
2013-08-02 13:11       ` Yan, Zheng
2013-08-01 11:52 ` [PATCH V5 3/8] memcg: check for proper lock held in mem_cgroup_update_page_stat Sha Zhengju
2013-08-01 14:34   ` Michal Hocko
2013-08-04 18:48   ` Greg Thelen
2013-08-01 11:53 ` [PATCH V5 4/8] memcg: add per cgroup dirty pages accounting Sha Zhengju
2013-08-01 11:54 ` [PATCH V5 5/8] memcg: add per cgroup writeback " Sha Zhengju
2013-08-01 14:53   ` Michal Hocko
2013-08-03  9:25     ` Sha Zhengju
2013-08-04 10:08       ` Michal Hocko
2013-08-22  9:46         ` Fwd: " Sha Zhengju
2013-08-22  9:50           ` [PATCH 1/4] memcg: remove MEMCG_NR_FILE_MAPPED Sha Zhengju
2013-08-22  9:52           ` [PATCH 2/4] memcg: check for proper lock held in mem_cgroup_update_page_stat Sha Zhengju
2013-08-22  9:53           ` [PATCH 3/4] memcg: add per cgroup writeback pages accounting Sha Zhengju
2013-08-22 22:40             ` Andrew Morton
2013-08-23 16:11               ` Sha Zhengju
2013-08-22  9:53           ` [PATCH 4/4] memcg: Document cgroup dirty/writeback memory statistics Sha Zhengju
2013-08-04 18:51   ` [PATCH V5 5/8] memcg: add per cgroup writeback pages accounting Greg Thelen
2013-08-01 11:55 ` [PATCH V5 6/8] memcg: make nocpu_base available for non-hotplug Sha Zhengju
2013-08-01 12:00 ` [PATCH V5 7/8] memcg: don't account root memcg page stats if only root exists Sha Zhengju
2013-08-01 16:20   ` Johannes Weiner
2013-08-02  4:32     ` Sha Zhengju
2013-08-05 21:58       ` Johannes Weiner
2013-08-01 12:00 ` [PATCH V5 8/8] memcg: Document cgroup dirty/writeback memory statistics Sha Zhengju
2013-08-01 14:43 ` Michal Hocko [this message]
2013-08-03  9:30   ` [PATCH V5 0/8] Add memcg dirty/writeback page accounting Sha Zhengju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130801144326.GI5198@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=glommer@gmail.com \
    --cc=gthelen@google.com \
    --cc=handai.szj@gmail.com \
    --cc=handai.szj@taobao.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox