From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx155.postini.com [74.125.245.155]) by kanga.kvack.org (Postfix) with SMTP id EB8DF6B0031 for ; Tue, 30 Jul 2013 22:36:14 -0400 (EDT) Date: Wed, 31 Jul 2013 11:36:13 +0900 From: Joonsoo Kim Subject: Re: [PATCH 03/18] mm, hugetlb: unify region structure handling Message-ID: <20130731023613.GB2548@lge.com> References: <1375075929-6119-1-git-send-email-iamjoonsoo.kim@lge.com> <1375075929-6119-4-git-send-email-iamjoonsoo.kim@lge.com> <87wqo8ot4m.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wqo8ot4m.fsf@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li , Naoya Horiguchi , Hillf Danton On Tue, Jul 30, 2013 at 10:57:37PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > Currently, to track a reserved and allocated region, we use two different > > ways for MAP_SHARED and MAP_PRIVATE. For MAP_SHARED, we use > > address_mapping's private_list and, for MAP_PRIVATE, we use a resv_map. > > Now, we are preparing to change a coarse grained lock which protect > > a region structure to fine grained lock, and this difference hinder it. > > So, before changing it, unify region structure handling. > > > > Signed-off-by: Joonsoo Kim > > > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > > index a3f868a..a1ae3ada 100644 > > --- a/fs/hugetlbfs/inode.c > > +++ b/fs/hugetlbfs/inode.c > > @@ -366,7 +366,12 @@ static void truncate_hugepages(struct inode *inode, loff_t lstart) > > > > static void hugetlbfs_evict_inode(struct inode *inode) > > { > > + struct resv_map *resv_map; > > + > > truncate_hugepages(inode, 0); > > + resv_map = (struct resv_map *)inode->i_mapping->private_data; > > + if (resv_map) > > can resv_map == NULL ? Hello, Aneesh. Yes, it can. root inode which is allocated in hugetlbfs_get_root() doesn't allocate a resv_map. > > > > + kref_put(&resv_map->refs, resv_map_release); > > Also the kref_put is confusing. For shared mapping we don't have ref > count incremented right ? So may be you can directly call > resv_map_release or add a comment around explaining this more ? Yes, I can call resv_map_release() directly, but I think that release via reference management is better than it. Thanks. > > > > clear_inode(inode); > > } > > > > @@ -468,6 +473,11 @@ static struct inode *hugetlbfs_get_inode(struct super_block *sb, > > umode_t mode, dev_t dev) > > { > > struct inode *inode; > > + struct resv_map *resv_map; > > + > > + resv_map = resv_map_alloc(); > > + if (!resv_map) > > + return NULL; > > -aneesh > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org