From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx128.postini.com [74.125.245.128]) by kanga.kvack.org (Postfix) with SMTP id 9A3B66B0033 for ; Tue, 30 Jul 2013 03:52:47 -0400 (EDT) Date: Tue, 30 Jul 2013 09:52:39 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 1/2] uio: provide vm access to UIO_MEM_PHYS maps Message-ID: <20130730075239.GN1754@pengutronix.de> References: <20130727214911.GK1754@pengutronix.de> <1374962978-1860-1-git-send-email-u.kleine-koenig@pengutronix.de> <20130729200914.GA6146@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130729200914.GA6146@kroah.com> Sender: owner-linux-mm@kvack.org List-ID: To: Greg Kroah-Hartman Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org, kernel@pengutronix.de, Andrew Morton , linux-mm@kvack.org [expanding Cc: to also include akpm and linux-mm] Hello, On Mon, Jul 29, 2013 at 01:09:14PM -0700, Greg Kroah-Hartman wrote: > On Sun, Jul 28, 2013 at 12:09:37AM +0200, Uwe Kleine-Konig wrote: > > This makes it possible to let gdb access mappings of the process that is > > being debugged. > > > > uio_mmap_logical was moved and uio_vm_ops renamed to group related code > > and differentiate to new stuff. > > > > Signed-off-by: Uwe Kleine-Konig > > --- > > Changes since v1: > > - only use generic_access_phys ifdef CONFIG_HAVE_IOREMAP_PROT > > - fix all users of renamed struct > > I still get a build error with this patch: > > MODPOST 384 modules > ERROR: "generic_access_phys" [drivers/uio/uio.ko] undefined! > > So something isn't quite right. Ah, you built as a module and generic_access_phys isn't exported. The other users of generic_access_phys (arch/x86/pci/i386.c and drivers/char/mem.c) can only be builtin. So the IMHO best option is to add an EXPORT_SYMBOL(generic_access_phys) to mm/memory.c. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-Konig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org