From: Peter Zijlstra <peterz@infradead.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Minchan Kim <minchan@kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hillf Danton <dhillf@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: hugepage related lockdep trace.
Date: Mon, 29 Jul 2013 17:20:01 +0200 [thread overview]
Message-ID: <20130729152001.GC22156@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20130729145308.GG4678@dhcp22.suse.cz>
On Mon, Jul 29, 2013 at 04:53:08PM +0200, Michal Hocko wrote:
> Peter, for you context the lockdep splat has been reported
> here: https://lkml.org/lkml/2013/7/17/381
>
> Minchan has proposed to workaround it by using SINGLE_DEPTH_NESTING
> https://lkml.org/lkml/2013/7/23/812
>
> my idea was to use a separate class key for hugetlb as it is quite
> special in many ways:
> https://lkml.org/lkml/2013/7/25/277
>
> What is the preferred way of fixing such an issue?
The class is the safer annotation.
That said; it is a rather horrible issue any which way. This PMD sharing
is very unique to hugetlbfs (also is that really worth the effort these
days?) and it will make it impossible to make hugetlbfs swappable.
The other solution is to make the pmd allocation GFP_NOFS.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-29 15:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 15:32 Dave Jones
2013-07-18 0:09 ` Minchan Kim
2013-07-18 17:42 ` Aneesh Kumar K.V
2013-07-19 0:13 ` Minchan Kim
2013-07-23 7:24 ` Hush Bensen
2013-07-24 2:57 ` Minchan Kim
2013-07-23 14:01 ` Michal Hocko
2013-07-24 2:44 ` Minchan Kim
2013-07-25 13:30 ` Michal Hocko
2013-07-29 8:24 ` Minchan Kim
2013-07-29 14:53 ` Michal Hocko
2013-07-29 15:20 ` Peter Zijlstra [this message]
2013-07-30 14:29 ` Michal Hocko
2013-07-30 14:46 ` [PATCH] hugetlb: fix lockdep splat caused by pmd sharing Michal Hocko
2013-07-30 14:58 ` Peter Zijlstra
2013-07-30 15:23 ` Michal Hocko
2013-07-30 23:35 ` Minchan Kim
2013-07-30 23:37 ` Dave Jones
2013-07-19 2:08 ` hugepage related lockdep trace Hillf Danton
2013-07-19 3:20 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729152001.GC22156@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=davej@redhat.com \
--cc=dhillf@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox