From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx171.postini.com [74.125.245.171]) by kanga.kvack.org (Postfix) with SMTP id 3C4856B0031 for ; Wed, 24 Jul 2013 18:43:04 -0400 (EDT) Date: Wed, 24 Jul 2013 15:43:01 -0700 From: Andrew Morton Subject: Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap Message-Id: <20130724154301.2af75867c51870fc0c32819b@linux-foundation.org> In-Reply-To: <51EDE903.6010608@ozlabs.ru> References: <1373936045-22653-1-git-send-email-aik@ozlabs.ru> <1373936045-22653-5-git-send-email-aik@ozlabs.ru> <51EDE903.6010608@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Alexey Kardashevskiy Cc: linuxppc-dev@lists.ozlabs.org, David Gibson , Benjamin Herrenschmidt , Paul Mackerras , Alexander Graf , Alex Williamson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, Yasuaki Ishimatsu , Martin Schwidefsky , Andrea Arcangeli , Mel Gorman On Tue, 23 Jul 2013 12:22:59 +1000 Alexey Kardashevskiy wrote: > Ping, anyone, please? ew, you top-posted. > Ben needs ack from any of MM people before proceeding with this patch. Thanks! For what? The three lines of comment in page-flags.h? ack :) Manipulating page->_count directly is considered poor form. Don't blame us if we break your code ;) Actually, the manipulation in realmode_get_page() duplicates the existing get_page_unless_zero() and the one in realmode_put_page() could perhaps be placed in mm.h with a suitable name and some documentation. That would improve your form and might protect the code from getting broken later on. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org