From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave@sr71.net>, Bob Liu <lliubbo@gmail.com>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: zswap: add runtime enable/disable
Date: Tue, 23 Jul 2013 12:22:30 -0500 [thread overview]
Message-ID: <20130723172230.GA5820@medulla.variantweb.net> (raw)
In-Reply-To: <20130722232529.GA23208@hacker.(null)>
On Tue, Jul 23, 2013 at 07:25:29AM +0800, Wanpeng Li wrote:
> On Mon, Jul 22, 2013 at 02:34:02PM -0500, Seth Jennings wrote:
> >@@ -612,7 +612,7 @@ static int zswap_frontswap_store(unsigned type, pgoff_t offset,
> > u8 *src, *dst;
> > struct zswap_header *zhdr;
> >
> >- if (!tree) {
> >+ if (!zswap_enabled || !tree) {
>
> If this check should be added to all hooks in zswap?
No. We want to continue to allow loads and invalidates since zswap will
still have pages stored it in. It just won't accept any new pages.
Seth
>
> > ret = -ENODEV;
> > goto reject;
> > }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-23 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 19:34 Seth Jennings
2013-07-22 23:25 ` Wanpeng Li
2013-07-22 23:25 ` Wanpeng Li
2013-07-23 17:22 ` Seth Jennings [this message]
2013-07-23 9:16 ` Bob Liu
2013-07-23 17:32 ` Seth Jennings
2013-07-23 20:08 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723172230.GA5820@medulla.variantweb.net \
--to=sjenning@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=lliubbo@gmail.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox