From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Christoph Lameter <cl@linux.com>
Cc: Chen Gang F T <chen.gang.flying.transformer@gmail.com>,
Chen Gang <gang.chen@asianux.com>,
Pekka Enberg <penberg@kernel.org>,
mpm@selenic.com, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/slub.c: add parameter length checking for alloc_loc_track()
Date: Mon, 22 Jul 2013 08:42:55 +0800 [thread overview]
Message-ID: <20130722004255.GA13225@hacker.(null)> (raw)
In-Reply-To: <0000013ff73897b8-9d8f4486-1632-470c-8f1f-caf44932cef1-000000@email.amazonses.com>
On Fri, Jul 19, 2013 at 01:57:28PM +0000, Christoph Lameter wrote:
>On Fri, 19 Jul 2013, Chen Gang F T wrote:
>
>> Yes, "'max' can roughly mean the same thing", but they are still a
>> little different.
>>
>> 'max' also means: "the caller tells callee: I have told you the
>> maximize buffer length, so I need not check the buffer length to be
>> sure of no memory overflow, you need be sure of it".
>>
>> 'size' means: "the caller tells callee: you should use the size which I
>> give you, I am sure it is OK, do not care about whether it can cause
>> memory overflow or not".
>
>Ok that makes sense.
>
>> The diff may like this:
>
>I am fine with such a patch.
>
>Ultimately I would like the tracking and debugging technology to be
>abstracted from the slub allocator and made generally useful by putting it
>into mm/slab_common.c. SLAB has similar things but does not have all the
>features.
Coincidence, I am doing this work recently and will post patches soon.
;-)
Regards,
Wanpeng Li
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-22 0:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 8:07 [PATCH] mm/slub.c: remove 'per_cpu' which is useless variable Chen Gang
2013-07-11 6:45 ` Pekka Enberg
2013-07-11 6:50 ` Chen Gang
2013-07-11 16:45 ` Christoph Lameter
2013-07-11 18:28 ` Pekka Enberg
2013-07-11 20:16 ` Christoph Lameter
2013-07-11 23:52 ` Chen Gang
2013-07-12 0:23 ` [PATCH v2] " Chen Gang
2013-07-12 0:55 ` [PATCH] mm/slub.c: add parameter length checking for alloc_loc_track() Chen Gang
2013-07-12 13:49 ` Christoph Lameter
2013-07-15 0:17 ` Chen Gang
2013-07-15 15:16 ` Christoph Lameter
2013-07-16 1:03 ` Chen Gang
2013-07-17 15:03 ` Christoph Lameter
2013-07-18 0:43 ` Chen Gang
2013-07-18 13:45 ` Christoph Lameter
2013-07-19 0:05 ` Chen Gang F T
2013-07-19 13:57 ` Christoph Lameter
2013-07-22 0:27 ` Chen Gang
2013-07-22 0:42 ` Wanpeng Li [this message]
2013-07-22 1:30 ` Chen Gang
2013-07-22 0:42 ` Wanpeng Li
2013-07-12 13:45 ` [PATCH v2] mm/slub.c: remove 'per_cpu' which is useless variable Christoph Lameter
2013-07-15 0:08 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130722004255.GA13225@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=chen.gang.flying.transformer@gmail.com \
--cc=cl@linux.com \
--cc=gang.chen@asianux.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox