From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Richard Davies <richard@arachsys.com>,
Shaohua Li <shli@kernel.org>, Rafael Aquini <aquini@redhat.com>,
Hush Bensen <hush.bensen@gmail.com>
Subject: Re: [PATCH 01/10] mm: zone_reclaim: remove ZONE_RECLAIM_LOCKED
Date: Wed, 17 Jul 2013 07:45:17 +0800 [thread overview]
Message-ID: <20130716234517.GE30164@hacker.(null)> (raw)
In-Reply-To: <1373982114-19774-2-git-send-email-aarcange@redhat.com>
On Tue, Jul 16, 2013 at 03:41:45PM +0200, Andrea Arcangeli wrote:
>Zone reclaim locked breaks zone_reclaim_mode=1. If more than one
>thread allocates memory at the same time, it forces a premature
>allocation into remote NUMA nodes even when there's plenty of clean
>cache to reclaim in the local nodes.
>
>Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
>Reviewed-by: Rik van Riel <riel@redhat.com>
>Acked-by: Rafael Aquini <aquini@redhat.com>
>Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>---
> include/linux/mmzone.h | 6 ------
> mm/vmscan.c | 4 ----
> 2 files changed, 10 deletions(-)
>
>diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
>index af4a3b7..9534a9a 100644
>--- a/include/linux/mmzone.h
>+++ b/include/linux/mmzone.h
>@@ -496,7 +496,6 @@ struct zone {
> } ____cacheline_internodealigned_in_smp;
>
> typedef enum {
>- ZONE_RECLAIM_LOCKED, /* prevents concurrent reclaim */
> ZONE_OOM_LOCKED, /* zone is in OOM killer zonelist */
> ZONE_CONGESTED, /* zone has many dirty pages backed by
> * a congested BDI
>@@ -540,11 +539,6 @@ static inline int zone_is_reclaim_writeback(const struct zone *zone)
> return test_bit(ZONE_WRITEBACK, &zone->flags);
> }
>
>-static inline int zone_is_reclaim_locked(const struct zone *zone)
>-{
>- return test_bit(ZONE_RECLAIM_LOCKED, &zone->flags);
>-}
>-
> static inline int zone_is_oom_locked(const struct zone *zone)
> {
> return test_bit(ZONE_OOM_LOCKED, &zone->flags);
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 2cff0d4..042fdcd 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3595,11 +3595,7 @@ int zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
> if (node_state(node_id, N_CPU) && node_id != numa_node_id())
> return ZONE_RECLAIM_NOSCAN;
>
>- if (zone_test_and_set_flag(zone, ZONE_RECLAIM_LOCKED))
>- return ZONE_RECLAIM_NOSCAN;
>-
> ret = __zone_reclaim(zone, gfp_mask, order);
>- zone_clear_flag(zone, ZONE_RECLAIM_LOCKED);
>
> if (!ret)
> count_vm_event(PGSCAN_ZONE_RECLAIM_FAILED);
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-16 23:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 13:41 [PATCH 00/10] adding compaction to zone_reclaim_mode > 0 #2 Andrea Arcangeli
2013-07-16 13:41 ` [PATCH 01/10] mm: zone_reclaim: remove ZONE_RECLAIM_LOCKED Andrea Arcangeli
2013-07-16 23:45 ` Wanpeng Li [this message]
2013-07-16 23:45 ` Wanpeng Li
2013-07-16 13:41 ` [PATCH 02/10] mm: zone_reclaim: compaction: scan all memory with /proc/sys/vm/compact_memory Andrea Arcangeli
2013-07-16 23:29 ` Wanpeng Li
2013-07-16 23:29 ` Wanpeng Li
2013-07-16 13:41 ` [PATCH 03/10] mm: zone_reclaim: compaction: don't depend on kswapd to invoke reset_isolation_suitable Andrea Arcangeli
2013-07-16 23:32 ` Wanpeng Li
2013-07-16 23:32 ` Wanpeng Li
2013-07-16 13:41 ` [PATCH 04/10] mm: zone_reclaim: compaction: reset before initializing the scan cursors Andrea Arcangeli
2013-07-16 23:31 ` Wanpeng Li
2013-07-16 23:31 ` Wanpeng Li
2013-07-16 13:41 ` [PATCH 05/10] mm: compaction: don't require high order pages below min wmark Andrea Arcangeli
2013-07-17 8:13 ` Hush Bensen
2013-07-17 17:15 ` Andrea Arcangeli
2013-07-16 13:41 ` [PATCH 06/10] mm: zone_reclaim: compaction: increase the high order pages in the watermarks Andrea Arcangeli
2013-07-16 13:41 ` [PATCH 07/10] mm: zone_reclaim: compaction: export compact_zone_order() Andrea Arcangeli
2013-07-16 13:41 ` [PATCH 08/10] mm: zone_reclaim: only run zone_reclaim in the fast path Andrea Arcangeli
2013-07-16 13:41 ` [PATCH 09/10] mm: zone_reclaim: after a successful zone_reclaim check the min watermark Andrea Arcangeli
2013-07-16 13:41 ` [PATCH 10/10] mm: zone_reclaim: compaction: add compaction to zone_reclaim_mode Andrea Arcangeli
2013-07-17 8:20 ` Hush Bensen
2013-07-17 17:20 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130716234517.GE30164@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=aquini@redhat.com \
--cc=hughd@google.com \
--cc=hush.bensen@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=richard@arachsys.com \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox