From: Tejun Heo <tj@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
cgroups@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Sha Zhengju <handai.szj@gmail.com>,
devel@openvz.org, Vivek Goyal <vgoyal@redhat.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH RFC] fsio: filesystem io accounting cgroup
Date: Mon, 8 Jul 2013 10:00:47 -0700 [thread overview]
Message-ID: <20130708170047.GA18600@mtj.dyndns.org> (raw)
In-Reply-To: <20130708100046.14417.12932.stgit@zurg>
(cc'ing Vivek and Jens)
Hello,
On Mon, Jul 08, 2013 at 02:01:39PM +0400, Konstantin Khlebnikov wrote:
> This is proof of concept, just basic functionality for IO controller.
> This cgroup will control filesystem usage on vfs layer, it's main goal is
> bandwidth control. It's supposed to be much more lightweight than memcg/blkio.
While blkcg is pretty heavy handed right now, there's no inherent
reason for it to be that way. The right thing to do would be updating
blkcg to be light-weight rather than adding yet another controller.
Also, all controllers should support full hierarchy.
> Unlike to blkio this method works for all of filesystems, not just disk-backed.
> Also it's able to handle writeback, because each inode has context which can be
> used in writeback thread to account io operations.
Again, a problem to be fixed in the stack rather than patching up from
up above. The right thing to do is to propagate pressure through bdi
properly and let whatever is backing the bdi generate appropriate
amount of pressure, be that disk or network.
> This is early prototype, I have some plans about extra functionality because
> this accounting itself is mostly useless, but it can be used as basis for more
> usefull features.
I'm afraid it'd have very low chance of making upstream. If this area
of work is interesting / important, please look into improving blkcg
rather than working around it.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-08 17:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 10:01 Konstantin Khlebnikov
2013-07-08 17:00 ` Tejun Heo [this message]
2013-07-08 17:52 ` Vivek Goyal
2013-07-08 17:56 ` Tejun Heo
2013-07-09 8:28 ` Konstantin Khlebnikov
2013-07-09 12:57 ` Tejun Heo
2013-07-09 13:15 ` Konstantin Khlebnikov
2013-07-09 13:16 ` Tejun Heo
2013-07-09 13:16 ` Tejun Heo
2013-07-09 13:43 ` Konstantin Khlebnikov
2013-07-09 13:45 ` Tejun Heo
2013-07-09 14:18 ` Vivek Goyal
2013-07-09 14:29 ` Tejun Heo
2013-07-09 14:54 ` Vivek Goyal
2013-07-09 15:08 ` Tejun Heo
[not found] ` <20130710030955.GA3569@redhat.com>
2013-07-10 3:50 ` Tejun Heo
2013-07-09 14:35 ` Konstantin Khlebnikov
2013-07-09 14:42 ` Tejun Heo
2013-07-09 15:06 ` Vivek Goyal
2013-07-09 17:42 ` Konstantin Khlebnikov
2013-07-09 18:35 ` Vivek Goyal
2013-07-09 20:54 ` Konstantin Khlebnikov
2013-07-08 18:11 ` Vivek Goyal
2013-07-09 15:39 ` Theodore Ts'o
2013-07-09 17:12 ` Konstantin Khlebnikov
-- strict thread matches above, loose matches on Subject: below --
2013-07-08 9:59 Konstantin Khlebnikov
2013-07-10 4:43 ` Sha Zhengju
2013-07-10 6:03 ` Konstantin Khlebnikov
2013-07-10 8:37 ` Sha Zhengju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708170047.GA18600@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=devel@openvz.org \
--cc=handai.szj@gmail.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox