From: Michal Hocko <mhocko@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] mm: Honor min_free_kbytes set by user
Date: Thu, 4 Jul 2013 18:20:05 +0200 [thread overview]
Message-ID: <20130704162005.GE7833@dhcp22.suse.cz> (raw)
In-Reply-To: <20130704161641.GD7833@dhcp22.suse.cz>
On Thu 04-07-13 18:16:41, Michal Hocko wrote:
> On Thu 04-07-13 09:10:39, Joe Perches wrote:
> > On Thu, 2013-07-04 at 18:07 +0200, Michal Hocko wrote:
> > > A warning is printed when the new value is ignored.
> >
> > []
> >
> > > + printk(KERN_WARNING "min_free_kbytes is not updated to %d"
> > > + "because user defined value %d is preferred\n",
> > > + new_min_free_kbytes, user_min_free_kbytes);
> >
> > Please use pr_warn and coalesce the format.
>
> Sure can do that. mm/page_alloc.c doesn't seem to be unified in that
> regards (44 printks and only 4 pr_<foo>) so I used printk.
>
> > You'd've noticed a missing space between %d and because.
>
> True
>
Checkpatch fixes
---
next prev parent reply other threads:[~2013-07-04 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 16:07 Michal Hocko
2013-07-04 16:10 ` Joe Perches
2013-07-04 16:16 ` Michal Hocko
2013-07-04 16:20 ` Michal Hocko [this message]
2013-07-04 16:35 ` Zhang Yanfei
2013-07-08 18:48 ` KOSAKI Motohiro
2013-07-09 23:40 ` Jiri Kosina
2013-07-10 6:57 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704162005.GE7833@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox