From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id 729956B0033 for ; Wed, 3 Jul 2013 14:33:19 -0400 (EDT) Date: Wed, 3 Jul 2013 20:32:43 +0200 From: Peter Zijlstra Subject: Re: [PATCH 13/13] sched: Account for the number of preferred tasks running on a node when selecting a preferred node Message-ID: <20130703183243.GB18898@dyad.programming.kicks-ass.net> References: <1372861300-9973-1-git-send-email-mgorman@suse.de> <1372861300-9973-14-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372861300-9973-14-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Wed, Jul 03, 2013 at 03:21:40PM +0100, Mel Gorman wrote: > --- > kernel/sched/fair.c | 45 ++++++++++++++++++++++++++++++++++++++++++--- > kernel/sched/sched.h | 4 ++++ > 2 files changed, 46 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 3c796b0..9ffdff3 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -777,6 +777,18 @@ update_stats_curr_start(struct cfs_rq *cfs_rq, struct sched_entity *se) > * Scheduling class queueing methods: > */ > > +static void account_numa_enqueue(struct rq *rq, struct task_struct *p) > +{ > + rq->nr_preferred_running += > + (cpu_to_node(task_cpu(p)) == p->numa_preferred_nid); > +} > + > +static void account_numa_dequeue(struct rq *rq, struct task_struct *p) > +{ > + rq->nr_preferred_running -= > + (cpu_to_node(task_cpu(p)) == p->numa_preferred_nid); > +} Ah doing this requires you dequeue before changing ->numa_preferred_nid. I don't remember seeing that change in this series. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org