From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx183.postini.com [74.125.245.183]) by kanga.kvack.org (Postfix) with SMTP id 5625B6B0032 for ; Fri, 28 Jun 2013 05:02:06 -0400 (EDT) Date: Fri, 28 Jun 2013 11:01:59 +0200 From: Peter Zijlstra Subject: Re: [PATCH 4/8] sched: Update NUMA hinting faults once per scan Message-ID: <20130628090159.GC28407@twins.programming.kicks-ass.net> References: <1372257487-9749-1-git-send-email-mgorman@suse.de> <1372257487-9749-5-git-send-email-mgorman@suse.de> <20130628063233.GC17195@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130628063233.GC17195@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Srikar Dronamraju Cc: Mel Gorman , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML On Fri, Jun 28, 2013 at 12:02:33PM +0530, Srikar Dronamraju wrote: > * Mel Gorman [2013-06-26 15:38:03]: > > @@ -831,9 +837,13 @@ void task_numa_fault(int node, int pages, bool migrated) > > if (unlikely(!p->numa_faults)) { > > int size = sizeof(*p->numa_faults) * nr_node_ids; > > > > - p->numa_faults = kzalloc(size, GFP_KERNEL); > > + /* numa_faults and numa_faults_buffer share the allocation */ > > + p->numa_faults = kzalloc(size * 2, GFP_KERNEL); > > Instead of allocating buffer to hold the current faults, cant we pass > the nr of pages and node information (and probably migrate) to > task_numa_placement()?. I'm afraid I don't get your question; there's more storage required than just the arguments. > Why should task_struct be passed as an argument to task_numa_placement(). > It seems it always will be current. Customary for parts -- motivated by the fact that usage of current is/can be more expensive than passing an argument. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org